Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 2653273004: [turbofan] Ensure {CheckMaps} is not used accross mutations. (Closed)

Created:
3 years, 11 months ago by Michael Starzinger
Modified:
3 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Ensure {CheckMaps} is not used accross mutations. This makes sure that static guarantees about object maps are not used accross operations on the effect chain that might trigger a map change. Such operations are missing the {Operator::kNoWrite} property. R=bmeurer@chromium.org TEST=mjsunit/regress/regress-crbug-685506 BUG=chromium:685506 Review-Url: https://codereview.chromium.org/2653273004 Cr-Commit-Position: refs/heads/master@{#42697} Committed: https://chromium.googlesource.com/v8/v8/+/e752bcc216384e496ee5eaaebd29f34d7182b517

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -1 line) Patch
M src/compiler/js-builtin-reducer.cc View 1 chunk +3 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-crbug-685506.js View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Michael Starzinger
3 years, 11 months ago (2017-01-26 11:45:40 UTC) #3
Benedikt Meurer
Awesome, thanks. LGTM.
3 years, 11 months ago (2017-01-26 12:15:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2653273004/1
3 years, 11 months ago (2017-01-26 12:55:18 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 12:57:10 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/e752bcc216384e496ee5eaaebd29f34d718...

Powered by Google App Engine
This is Rietveld 408576698