Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2653203003: Migrate WTF::Vector::append() to ::push_back() [part 17 of N] (Closed)

Created:
3 years, 11 months ago by pilgrim_google
Modified:
3 years, 11 months ago
CC:
aboxhall, aboxhall+watch_chromium.org, atotic+reviews_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, cbiesinger, chromium-reviews, dgrogan+ng_chromium.org, dmazzoni, dmazzoni+watch_chromium.org, krit, dtseng+watch_chromium.org, eae+blinkwatch, f(malita), fs, glebl+reviews_chromium.org, gyuyoung2, jchaffraix+rendering, je_julie, kouhei+svg_chromium.org, leviw+renderwatch, nektarios, nektar+watch_chromium.org, ojan+watch_chromium.org, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, yuzo+watch_chromium.org, zoltan1, jsbell
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate WTF::Vector::append() to ::push_back() [part 17 of N] As discussed on platform-architecture-dev [0], there is interest in normalizing the methods of WTF classes to better align with std classes. This CL fixes a number of scattered references to append() that were missed in previous CLs or added to the code since then. There are no functional changes. [0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion BUG=662431 Review-Url: https://codereview.chromium.org/2653203003 Cr-Commit-Position: refs/heads/master@{#446074} Committed: https://chromium.googlesource.com/chromium/src/+/54aad911b25fd13622a400c73fc8b3bd0026ebda

Patch Set 1 #

Messages

Total messages: 12 (8 generated)
pilgrim_google
3 years, 11 months ago (2017-01-25 16:16:29 UTC) #3
haraken
LGTM
3 years, 11 months ago (2017-01-25 16:50:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2653203003/1
3 years, 11 months ago (2017-01-25 19:00:17 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 19:09:00 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/54aad911b25fd13622a400c73fc8...

Powered by Google App Engine
This is Rietveld 408576698