Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2653203002: Use entities in CommonElements interface. (Closed)

Created:
3 years, 11 months ago by Johnni Winther
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -176 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 5 chunks +9 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/constants/expressions.dart View 15 chunks +15 lines, -15 lines 0 comments Download
M pkg/compiler/lib/src/core_types.dart View 1 chunk +60 lines, -66 lines 0 comments Download
M pkg/compiler/lib/src/elements/resolution_types.dart View 4 chunks +12 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/builder.dart View 3 chunks +6 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_helpers.dart View 4 chunks +11 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_impact.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/namer.dart View 1 chunk +6 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/runtime_types.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/lazy_emitter/emitter.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/emitter.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/class_hierarchy.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/enum_creator.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 8 chunks +17 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 2 chunks +7 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/resolution/signatures.dart View 1 chunk +9 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/typechecker.dart View 7 chunks +21 lines, -12 lines 0 comments Download
M tests/compiler/dart2js/minimal_resolution_test.dart View 1 chunk +3 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/related_types.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/type_checker_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/type_combination_test.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 11 months ago (2017-01-25 14:12:18 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 11 months ago (2017-01-25 17:00:10 UTC) #3
Johnni Winther
3 years, 11 months ago (2017-01-26 09:29:22 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
a3d0329735ab522864f9be561c35da9d5c4dc214 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698