pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart - Issue 2653203002: Use entities in CommonElements interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

Issue 2653203002: Use entities in CommonElements interface. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/js_emitter/lazy_emitter/emitter.dart ('k') | pkg/compiler/lib/src/js_emitter/startup_emitter/emitter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

diff --git a/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart b/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

index 3f612d3ca002ddeadc0b828882e27cbdb5dd48c9..79eff9ac5d79f63e099f90313b26974df45720af 100644

--- a/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

+++ b/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

@@ -29,6 +29,7 @@ import '../../elements/elements.dart'

ParameterElement,

TypedefElement,

VariableElement;

+import '../../elements/types.dart' show DartType;

import '../../js/js.dart' as js;

import '../../js_backend/backend_helpers.dart' show BackendHelpers;

import '../../js_backend/js_backend.dart'

@@ -396,8 +397,8 @@ class ProgramBuilder {

if (returnType.isFunctionType) {

functionType = returnType;

} else if (returnType.treatAsDynamic ||

- _compiler.types.isSubtype(

- returnType, backend.commonElements.functionType)) {

+ _compiler.types.isSubtype(returnType,

+ backend.commonElements.functionType as DartType)) {

if (returnType.isTypedef) {

ResolutionTypedefType typedef = returnType;

// TODO(jacobr): can we just use typdef.unaliased instead?