Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 2653183009: Revert of Don't offer to translate between Simplified and Traditional Chinese (Closed)

Created:
3 years, 10 months ago by Dan Beam
Modified:
3 years, 10 months ago
Reviewers:
groby-ooo-7-16, riesa
CC:
chromium-reviews, Anton Bakalov
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Don't offer to translate between Simplified and Traditional Chinese (patchset #5 id:80001 of https://codereview.chromium.org/2650003004/ ) Reason for revert: Causing sizes failure on Linux: https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/31922/steps/sizes/logs/stdio # translate_manager.cc std::ios_base::Init::Init()@plt # translate_manager.cc std::__ioinit [#includes <iostream>, use <ostream> instead] # translate_manager.cc __cxa_atexit@plt [registers a dtor to run at exit] # translate_manager.cc __dso_handle # translate_manager.cc __init_array_end+0x968 Original issue's description: > Don't offer to translate between Simplified and Traditional Chinese. > > BUG=683164 > > Review-Url: https://codereview.chromium.org/2650003004 > Cr-Commit-Position: refs/heads/master@{#446213} > Committed: https://chromium.googlesource.com/chromium/src/+/889fb1a6efab0b3e425b81575bbd7a62ed0c4eb1 TBR=groby@chromium.org,riesa@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=683164 Review-Url: https://codereview.chromium.org/2653183009 Cr-Commit-Position: refs/heads/master@{#446232} Committed: https://chromium.googlesource.com/chromium/src/+/fc1f65c1189b644cd27c8a5fa47861dd4f68859d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -63 lines) Patch
M components/translate/core/browser/translate_manager.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M components/translate/core/browser/translate_manager_unittest.cc View 1 chunk +0 lines, -58 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Dan Beam
Created Revert of Don't offer to translate between Simplified and Traditional Chinese
3 years, 10 months ago (2017-01-26 05:25:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2653183009/1
3 years, 10 months ago (2017-01-26 05:25:48 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-01-26 05:27:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fc1f65c1189b644cd27c8a5fa478...

Powered by Google App Engine
This is Rietveld 408576698