Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 2653183008: cc : Remove usage of combined_clip_in_target_space during hit testing. (Closed)

Created:
3 years, 11 months ago by jaydasika
Modified:
3 years, 11 months ago
Reviewers:
ajuma, weiliangc
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc : Remove usage of combined_clip_in_target_space during hit testing. This is equivalent to the current logic because, if a point is clipped by combined_clip stored on clip node, it should be clipped by the local clip of some ancestor clip node. This CL is needed to delete combined_clip from clip nodes. BUG=594675 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2653183008 Cr-Commit-Position: refs/heads/master@{#446599} Committed: https://chromium.googlesource.com/chromium/src/+/a9661a4d68e451c3d351e4a0a50a830b7ab7803c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -22 lines) Patch
M cc/trees/layer_tree_impl.cc View 1 chunk +8 lines, -22 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
jaydasika
PTAL
3 years, 11 months ago (2017-01-26 00:28:47 UTC) #3
weiliangc
LGTM
3 years, 11 months ago (2017-01-26 23:14:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2653183008/1
3 years, 11 months ago (2017-01-27 03:33:13 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-27 05:08:23 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a9661a4d68e451c3d351e4a0a50a...

Powered by Google App Engine
This is Rietveld 408576698