Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2653163002: Disable parallelization on telemetry_unittests & set the number of shards to 2 (linux) (Closed)

Created:
3 years, 11 months ago by nednguyen
Modified:
3 years, 11 months ago
Reviewers:
Dirk Pranke, jam
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable parallelization on telemetry_unittests & set the number of shards to 2 (linux) It's a known problem that launching browsers in parallel on Linux will cause the test to hang due to deadlock ( https://github.com/catapult-project/catapult/issues/3074#issuecomment-266562500), and since each hang test takes 1 min timeout, so we disable telemetry parallelization & shards it on 2 machines to reduce the overall wait time. BUG=676742 Review-Url: https://codereview.chromium.org/2653163002 Cr-Commit-Position: refs/heads/master@{#445998} Committed: https://chromium.googlesource.com/chromium/src/+/027b82c601d86240ce7cdfe1f08b2f73eebbe840

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -5 lines) Patch
M testing/buildbot/chromium.fyi.json View 2 chunks +10 lines, -2 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 3 chunks +15 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
nednguyen
3 years, 11 months ago (2017-01-25 01:01:20 UTC) #2
nednguyen
On 2017/01/25 01:01:20, nednguyen wrote: The tests are much more stable now on Linux: Shard ...
3 years, 11 months ago (2017-01-25 01:50:54 UTC) #6
Dirk Pranke
lgtm
3 years, 11 months ago (2017-01-25 02:46:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2653163002/1
3 years, 11 months ago (2017-01-25 11:54:37 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/027b82c601d86240ce7cdfe1f08b2f73eebbe840
3 years, 11 months ago (2017-01-25 11:59:06 UTC) #14
jam
3 years, 11 months ago (2017-01-25 17:05:49 UTC) #15
Message was sent while issue was closed.
If it's taking 700s in one shard, that's too long. We aim to make each shard
take 5 minutes. Can you use 4 shards instead?

Powered by Google App Engine
This is Rietveld 408576698