Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2653153002: [Android] Roll the support library to 25.1.0. (Closed)

Created:
3 years, 11 months ago by jbudorick
Modified:
3 years, 11 months ago
Reviewers:
Ian Wen, amineer
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Roll the support library to 25.1.0. BUG= Review-Url: https://codereview.chromium.org/2653153002 Cr-Commit-Position: refs/heads/master@{#446102} Committed: https://chromium.googlesource.com/chromium/src/+/0cd7305003b4086ad86ce9ada35cbb8fe64bd281

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M build/secondary/third_party/android_tools/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
jbudorick
3 years, 11 months ago (2017-01-25 19:49:36 UTC) #6
Ian Wen
lgtm
3 years, 11 months ago (2017-01-25 19:54:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2653153002/1
3 years, 11 months ago (2017-01-25 20:10:03 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/0cd7305003b4086ad86ce9ada35cbb8fe64bd281
3 years, 11 months ago (2017-01-25 20:15:33 UTC) #12
ajuma
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2655923004/ by ajuma@chromium.org. ...
3 years, 11 months ago (2017-01-26 00:45:22 UTC) #13
ajuma
On 2017/01/26 00:45:22, ajuma wrote: > A revert of this CL (patchset #1 id:1) has ...
3 years, 11 months ago (2017-01-26 02:36:28 UTC) #14
jbudorick
3 years, 11 months ago (2017-01-26 02:38:41 UTC) #15
Message was sent while issue was closed.
On 2017/01/26 02:36:28, ajuma wrote:
> On 2017/01/26 00:45:22, ajuma wrote:
> > A revert of this CL (patchset #1 id:1) has been created in
> > https://codereview.chromium.org/2655923004/ by mailto:ajuma@chromium.org.
> > 
> > The reason for reverting is: Speculative revert to fix test failures on all
> the
> > Android GPU FYI bots.
> > 
> > The Nexus 6, Nexus 6P, Nexus 9, and Pixel C bots on the GPU FYI waterfall
all
> > started failing WebGL conformance tests and this CL seems the most
suspicious
> in
> > the common regression range (446100:446109).
> > 
> > Bot logs:
> >
>
https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Release%20%2...
> >
>
https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Release%20%2...
> >
>
https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Release%20%2...
> >
>
https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Release%20%2....
> 
> Revert seems to have done the trick, tests are passing again.

that's ... surprising. I'll be interested to see if they stay that way
overnight.

Powered by Google App Engine
This is Rietveld 408576698