Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2653123003: Revert of [i18n] chromeos first run, i18n-content to $i18n{} (Closed)

Created:
3 years, 11 months ago by dschuyler
Modified:
3 years, 11 months ago
Reviewers:
tommycli
CC:
chromium-reviews, alemate+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [i18n] chromeos first run, i18n-content to $i18n{} (patchset #1 id:1 of https://codereview.chromium.org/2625873006/ ) Reason for revert: This CL appears to have brought about this issue: https://bugs.chromium.org/p/chromium/issues/detail?id=684654&q=owner%3Ame&colspec=ID%20Pri%20M%20Stars%20ReleaseBlock%20Component%20Status%20Owner%20Summary%20OS%20Modified I'd like to revert this as a quick fix and then look into the issue further at a later time. Original issue's description: > [i18n] chromeos first run, i18n-content to $i18n{} > > This is a mechanical change to convert i18n-content to $i18n{} tags. > > BUG=677338 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Review-Url: https://codereview.chromium.org/2625873006 > Cr-Commit-Position: refs/heads/master@{#443108} > Committed: https://chromium.googlesource.com/chromium/src/+/2b7b8dafe5412ef81b6c4755bdbf700bd55d138a TBR=tommycli@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=677338 Review-Url: https://codereview.chromium.org/2653123003 Cr-Commit-Position: refs/heads/master@{#445935} Committed: https://chromium.googlesource.com/chromium/src/+/900b07d425120a680d173ee841d0c7dcc75180a2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -25 lines) Patch
M chrome/browser/resources/chromeos/first_run/app/main.html View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/chromeos/first_run/app_list_step.html View 1 chunk +5 lines, -6 lines 0 comments Download
M chrome/browser/resources/chromeos/first_run/help_step.html View 1 chunk +7 lines, -9 lines 0 comments Download
M chrome/browser/resources/chromeos/first_run/tray_step.html View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
dschuyler
Created Revert of [i18n] chromeos first run, i18n-content to $i18n{}
3 years, 11 months ago (2017-01-25 01:31:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2653123003/1
3 years, 11 months ago (2017-01-25 01:32:38 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 03:52:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/900b07d425120a680d173ee841d0...

Powered by Google App Engine
This is Rietveld 408576698