Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 265303002: Revert of Relocate suspended generator activations when enabling debug mode (Closed)

Created:
6 years, 7 months ago by wingo
Modified:
6 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Revert of Relocate suspended generator activations when enabling debug mode (https://codereview.chromium.org/260423002/) Reason for revert: Rolling out for build breakage ('Tree is closed (Automatic: "compile" on "V8 Win64" from 21141: wingo@igalia.com)') Original issue's description: > Relocate suspended generator activations when enabling debug mode > > R=yangguo@chromium.org > BUG=v8:3289 > LOG=N > > Committed: https://code.google.com/p/v8/source/detail?r=21141 TBR=yangguo@chromium.org,mstarzinger@chromium.org NOTREECHECKS=true NOTRY=true BUG=v8:3289

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -241 lines) Patch
M src/debug.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/debug.cc View 7 chunks +73 lines, -170 lines 0 comments Download
M src/objects.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 chunk +0 lines, -5 lines 0 comments Download
D test/mjsunit/harmony/generators-relocation.js View 1 chunk +0 lines, -61 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
wingo
Created Revert of Relocate suspended generator activations when enabling debug mode
6 years, 7 months ago (2014-05-05 13:24:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://v8-status.appspot.com/cq/wingo@igalia.com/265303002/1
6 years, 7 months ago (2014-05-05 13:25:10 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-05 13:25:11 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-05-05 13:25:12 UTC) #4
Yang
On 2014/05/05 13:25:12, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
6 years, 7 months ago (2014-05-05 13:25:47 UTC) #5
Yang
On 2014/05/05 13:25:47, Yang wrote: > On 2014/05/05 13:25:12, I haz the power (commit-bot) wrote: ...
6 years, 7 months ago (2014-05-05 13:26:34 UTC) #6
Yang
6 years, 7 months ago (2014-05-05 13:29:12 UTC) #7
On 2014/05/05 13:26:34, Yang wrote:
> On 2014/05/05 13:25:47, Yang wrote:
> > On 2014/05/05 13:25:12, I haz the power (commit-bot) wrote:
> > > No LGTM from a valid reviewer yet. Only full committers are accepted.
> > > Even if an LGTM may have been provided, it was from a non-committer or
> > > a provisional committer, _not_ a full super star committer.
> > > See http://www.chromium.org/getting-involved/become-a-committer
> > > Note that this has nothing to do with OWNERS files.
> > Lgtm
> 
> CQ doesnt work, unfortunately.

Seems to be already taken care of.

Powered by Google App Engine
This is Rietveld 408576698