Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: chrome/browser/prerender/prerender_contents.h

Issue 2653023002: Convert PrerenderContents to use the new navigation callbacks. (Closed)
Patch Set: fix DidFinishNavigation for error URL not giving an error early enough Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prerender/prerender_contents.h
diff --git a/chrome/browser/prerender/prerender_contents.h b/chrome/browser/prerender/prerender_contents.h
index 3d2a82c63296d0c7b77b719b0eae477a8799fb21..1926ce3a0fe8e7cf5f247745a22367c13a326385 100644
--- a/chrome/browser/prerender/prerender_contents.h
+++ b/chrome/browser/prerender/prerender_contents.h
@@ -170,15 +170,12 @@ class PrerenderContents : public content::NotificationObserver,
void DidStopLoading() override;
void DocumentLoadedInFrame(
content::RenderFrameHost* render_frame_host) override;
- void DidStartProvisionalLoadForFrame(
- content::RenderFrameHost* render_frame_host,
- const GURL& validated_url,
- bool is_error_page) override;
+ void DidStartNavigation(
+ content::NavigationHandle* navigation_handle) override;
void DidFinishLoad(content::RenderFrameHost* render_frame_host,
const GURL& validated_url) override;
- void DidNavigateMainFrame(
pasko 2017/01/25 17:34:28 note: there is a concurrent review that changes be
jam 2017/01/25 18:13:18 Sure, I'll wait for that cl to land before committ
- const content::LoadCommittedDetails& details,
- const content::FrameNavigateParams& params) override;
+ void DidFinishNavigation(
+ content::NavigationHandle* navigation_handle) override;
void DidGetRedirectForResourceRequest(
const content::ResourceRedirectDetails& details) override;
« no previous file with comments | « no previous file | chrome/browser/prerender/prerender_contents.cc » ('j') | chrome/browser/prerender/prerender_contents.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698