Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: chrome/browser/prerender/prerender_contents.h

Issue 2653023002: Convert PrerenderContents to use the new navigation callbacks. (Closed)
Patch Set: fix DidFinishNavigation for error URL not giving an error early enough Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PRERENDER_PRERENDER_CONTENTS_H_ 5 #ifndef CHROME_BROWSER_PRERENDER_PRERENDER_CONTENTS_H_
6 #define CHROME_BROWSER_PRERENDER_PRERENDER_CONTENTS_H_ 6 #define CHROME_BROWSER_PRERENDER_PRERENDER_CONTENTS_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 152 matching lines...) Expand 10 before | Expand all | Expand 10 after
163 // |url| and |session_storage_namespace|. 163 // |url| and |session_storage_namespace|.
164 bool Matches( 164 bool Matches(
165 const GURL& url, 165 const GURL& url,
166 const content::SessionStorageNamespace* session_storage_namespace) const; 166 const content::SessionStorageNamespace* session_storage_namespace) const;
167 167
168 // content::WebContentsObserver implementation. 168 // content::WebContentsObserver implementation.
169 void RenderFrameCreated(content::RenderFrameHost* render_frame_host) override; 169 void RenderFrameCreated(content::RenderFrameHost* render_frame_host) override;
170 void DidStopLoading() override; 170 void DidStopLoading() override;
171 void DocumentLoadedInFrame( 171 void DocumentLoadedInFrame(
172 content::RenderFrameHost* render_frame_host) override; 172 content::RenderFrameHost* render_frame_host) override;
173 void DidStartProvisionalLoadForFrame( 173 void DidStartNavigation(
174 content::RenderFrameHost* render_frame_host, 174 content::NavigationHandle* navigation_handle) override;
175 const GURL& validated_url,
176 bool is_error_page) override;
177 void DidFinishLoad(content::RenderFrameHost* render_frame_host, 175 void DidFinishLoad(content::RenderFrameHost* render_frame_host,
178 const GURL& validated_url) override; 176 const GURL& validated_url) override;
179 void DidNavigateMainFrame( 177 void DidFinishNavigation(
pasko 2017/01/25 17:34:28 note: there is a concurrent review that changes be
jam 2017/01/25 18:13:18 Sure, I'll wait for that cl to land before committ
180 const content::LoadCommittedDetails& details, 178 content::NavigationHandle* navigation_handle) override;
181 const content::FrameNavigateParams& params) override;
182 void DidGetRedirectForResourceRequest( 179 void DidGetRedirectForResourceRequest(
183 const content::ResourceRedirectDetails& details) override; 180 const content::ResourceRedirectDetails& details) override;
184 181
185 void RenderProcessGone(base::TerminationStatus status) override; 182 void RenderProcessGone(base::TerminationStatus status) override;
186 183
187 // content::NotificationObserver 184 // content::NotificationObserver
188 void Observe(int type, 185 void Observe(int type,
189 const content::NotificationSource& source, 186 const content::NotificationSource& source,
190 const content::NotificationDetails& details) override; 187 const content::NotificationDetails& details) override;
191 188
(...skipping 182 matching lines...) Expand 10 before | Expand all | Expand 10 after
374 int64_t network_bytes_; 371 int64_t network_bytes_;
375 372
376 base::WeakPtrFactory<PrerenderContents> weak_factory_; 373 base::WeakPtrFactory<PrerenderContents> weak_factory_;
377 374
378 DISALLOW_COPY_AND_ASSIGN(PrerenderContents); 375 DISALLOW_COPY_AND_ASSIGN(PrerenderContents);
379 }; 376 };
380 377
381 } // namespace prerender 378 } // namespace prerender
382 379
383 #endif // CHROME_BROWSER_PRERENDER_PRERENDER_CONTENTS_H_ 380 #endif // CHROME_BROWSER_PRERENDER_PRERENDER_CONTENTS_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/prerender/prerender_contents.cc » ('j') | chrome/browser/prerender/prerender_contents.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698