Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2652923003:
Enable linux_chromium_tsan_rel_ng on CQ for realz. (Closed)
DescriptionEnable linux_chromium_tsan_rel_ng on CQ for realz.
It's working great @ 100%, time to make it real:
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_tsan_rel_ng
BUG=672860
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_tsan_rel_ng
Review-Url: https://codereview.chromium.org/2652923003
Cr-Commit-Position: refs/heads/master@{#446308}
Committed: https://chromium.googlesource.com/chromium/src/+/5c98db656aa52625137af840e098bbce26db7010
Patch Set 1 #
Depends on Patchset: Dependent Patchsets: Messages
Total messages: 19 (10 generated)
Description was changed from ========== Enable linux_chromium_tsan_rel_ng on CQ for realz. It's working great @ 100%, time to make it real: https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium... BUG=672860 ========== to ========== Enable linux_chromium_tsan_rel_ng on CQ for realz. It's working great @ 100%, time to make it real: https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium... BUG=672860 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_tsan_rel_ng ==========
gab@chromium.org changed reviewers: + dpranke@chromium.org
The CQ bit was checked by gab@chromium.org to run a CQ dry run
Dirk PTAL :)!
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
dpranke@chromium.org changed reviewers: + phajdan.jr@chromium.org
lgtm. phajdan.jr, fyi ...
Just checking, did you check metrics e.g. at https://goto.google.com/dzaaq ? 50th percentile cycle time seems to sometimes exceed 60 minutes, which may jeopardize our goal of 60 minutes 50% cycle time for CQ.
On 2017/01/25 11:33:53, Paweł Hajdan Jr. wrote: > Just checking, did you check metrics e.g. at https://goto.google.com/dzaaq ? > > 50th percentile cycle time seems to sometimes exceed 60 minutes, which may > jeopardize our goal of 60 minutes 50% cycle time for CQ. I hadn't but it seems similar to the ASAN bot (same spike above 60): https://viceroy.corp.google.com/chrome_infra/Buildbot/per_builder?master=mast... And is sure better than the win bot: https://viceroy.corp.google.com/chrome_infra/Buildbot/per_builder?master=mast... Do we have aggregate stats on the last bot to finish a run? If TSAN becomes the main bottleneck in the CQ we can look into it but otherwise it shouldn't matter?
On 2017/01/25 11:33:53, Paweł Hajdan Jr. wrote: > Just checking, did you check metrics e.g. at https://goto.google.com/dzaaq ? > > 50th percentile cycle time seems to sometimes exceed 60 minutes, which may > jeopardize our goal of 60 minutes 50% cycle time for CQ. Urk, good catch, I did not check the cycle time. Let me look into it more.
On 2017/01/25 19:01:33, Dirk Pranke wrote: > On 2017/01/25 11:33:53, Paweł Hajdan Jr. wrote: > > Just checking, did you check metrics e.g. at https://goto.google.com/dzaaq ? > > > > 50th percentile cycle time seems to sometimes exceed 60 minutes, which may > > jeopardize our goal of 60 minutes 50% cycle time for CQ. > > Urk, good catch, I did not check the cycle time. > > Let me look into it more. Right, it looks like content_browsertests isn't sharded, and is taking ~30 minutes to run on "Linux TSAN Tests", which is much too slow. I suggest changing that to 5 shards first (in //testing/buildbot/chromium.memory.json).
On 2017/01/25 20:10:35, Dirk Pranke wrote: > On 2017/01/25 19:01:33, Dirk Pranke wrote: > > On 2017/01/25 11:33:53, Paweł Hajdan Jr. wrote: > > > Just checking, did you check metrics e.g. at https://goto.google.com/dzaaq ? > > > > > > 50th percentile cycle time seems to sometimes exceed 60 minutes, which may > > > jeopardize our goal of 60 minutes 50% cycle time for CQ. > > > > Urk, good catch, I did not check the cycle time. > > > > Let me look into it more. > > Right, it looks like content_browsertests isn't sharded, and is taking ~30 > minutes to run on "Linux TSAN Tests", which is much too slow. I suggest changing > that to 5 shards first (in //testing/buildbot/chromium.memory.json). Awesome, that landed yesterday and the cycle time is now much below 60s :) : https://goto.google.com/dzaaq
The CQ bit was checked by gab@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1485434092791170, "parent_rev":
"e9c70e53e5da9b0065ef7f5c6ce78d5b46e49875", "commit_rev":
"5c98db656aa52625137af840e098bbce26db7010"}
Message was sent while issue was closed.
Description was changed from ========== Enable linux_chromium_tsan_rel_ng on CQ for realz. It's working great @ 100%, time to make it real: https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium... BUG=672860 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_tsan_rel_ng ========== to ========== Enable linux_chromium_tsan_rel_ng on CQ for realz. It's working great @ 100%, time to make it real: https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium... BUG=672860 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_tsan_rel_ng Review-Url: https://codereview.chromium.org/2652923003 Cr-Commit-Position: refs/heads/master@{#446308} Committed: https://chromium.googlesource.com/chromium/src/+/5c98db656aa52625137af840e098... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/5c98db656aa52625137af840e098... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
