Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 2652903005: Use the manifest start URL to query the existence of a WebAPK (Closed)

Created:
3 years, 11 months ago by dominickn
Modified:
3 years, 11 months ago
Reviewers:
Xi Han, pkotwicz
CC:
chromium-reviews, dominickn+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use the manifest start URL to query the existence of a WebAPK This corrects an oversight where the last committed URL was used instead of the manifest start URL when checking whether a WebAPK was already installed. BUG=684986 Review-Url: https://codereview.chromium.org/2652903005 Cr-Commit-Position: refs/heads/master@{#445937} Committed: https://chromium.googlesource.com/chromium/src/+/5d09ddc4ab402628be6dad227726cf78dc486a55

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M chrome/browser/android/banners/app_banner_infobar_delegate_android.cc View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
dominickn
Xi (or Peter on the cc list) - PTAL. I think this is the right ...
3 years, 11 months ago (2017-01-25 00:21:58 UTC) #4
pkotwicz
LGTM. Thank you very much for catching this bug Dominick!
3 years, 11 months ago (2017-01-25 03:21:17 UTC) #8
pkotwicz
LGTM. Thank you very much for catching this bug Dominick!
3 years, 11 months ago (2017-01-25 03:21:20 UTC) #9
dominickn
On 2017/01/25 03:21:20, pkotwicz wrote: > LGTM. Thank you very much for catching this bug ...
3 years, 11 months ago (2017-01-25 03:50:24 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652903005/1
3 years, 11 months ago (2017-01-25 03:50:30 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 03:55:03 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5d09ddc4ab402628be6dad227726...

Powered by Google App Engine
This is Rietveld 408576698