Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1805)

Issue 2652903002: Convert MimeHandlerStreamManager to use the new navigation callbacks. (Closed)

Created:
3 years, 11 months ago by jam
Modified:
3 years, 11 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, ananta
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert MimeHandlerStreamManager to use the new navigation callbacks. BUG=682002 Review-Url: https://codereview.chromium.org/2652903002 Cr-Commit-Position: refs/heads/master@{#445884} Committed: https://chromium.googlesource.com/chromium/src/+/34daea6e90246c16505840ff3d75991ef34e8a2d

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -16 lines) Patch
M extensions/browser/guest_view/mime_handler_view/mime_handler_stream_manager.cc View 1 3 chunks +14 lines, -16 lines 0 comments Download

Messages

Total messages: 26 (20 generated)
jam
3 years, 11 months ago (2017-01-24 06:35:43 UTC) #16
jam
Switching to Istiaque who reviewed the previous change.
3 years, 11 months ago (2017-01-24 15:58:09 UTC) #18
lazyboy
lgtm /cc ananta@ for FYI https://codereview.chromium.org/2652903002/diff/40001/extensions/browser/guest_view/mime_handler_view/mime_handler_stream_manager.cc File extensions/browser/guest_view/mime_handler_view/mime_handler_stream_manager.cc (right): https://codereview.chromium.org/2652903002/diff/40001/extensions/browser/guest_view/mime_handler_view/mime_handler_stream_manager.cc#newcode208 extensions/browser/guest_view/mime_handler_view/mime_handler_stream_manager.cc:208: !IsTrackedRenderFrameHost(navigation_handle->GetRenderFrameHost())) nit: {}
3 years, 11 months ago (2017-01-24 23:22:14 UTC) #19
jam
https://codereview.chromium.org/2652903002/diff/40001/extensions/browser/guest_view/mime_handler_view/mime_handler_stream_manager.cc File extensions/browser/guest_view/mime_handler_view/mime_handler_stream_manager.cc (right): https://codereview.chromium.org/2652903002/diff/40001/extensions/browser/guest_view/mime_handler_view/mime_handler_stream_manager.cc#newcode208 extensions/browser/guest_view/mime_handler_view/mime_handler_stream_manager.cc:208: !IsTrackedRenderFrameHost(navigation_handle->GetRenderFrameHost())) On 2017/01/24 23:22:14, lazyboy wrote: > nit: {} ...
3 years, 11 months ago (2017-01-24 23:38:39 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652903002/60001
3 years, 11 months ago (2017-01-24 23:41:14 UTC) #23
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 00:52:21 UTC) #26
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/34daea6e90246c16505840ff3d75...

Powered by Google App Engine
This is Rietveld 408576698