|
|
Chromium Code Reviews
DescriptionConvert MimeHandlerStreamManager to use the new navigation callbacks.
BUG=682002
Review-Url: https://codereview.chromium.org/2652903002
Cr-Commit-Position: refs/heads/master@{#445884}
Committed: https://chromium.googlesource.com/chromium/src/+/34daea6e90246c16505840ff3d75991ef34e8a2d
Patch Set 1 #
Total comments: 2
Patch Set 2 : nit #Messages
Total messages: 26 (20 generated)
The CQ bit was checked by jam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by jam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by jam@chromium.org to run a CQ dry run
Patchset #2 (id:20001) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:1) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
jam@chromium.org changed reviewers: + raymes@chromium.org
jam@chromium.org changed reviewers: + lazyboy@chromium.org - raymes@chromium.org
Switching to Istiaque who reviewed the previous change.
lgtm /cc ananta@ for FYI https://codereview.chromium.org/2652903002/diff/40001/extensions/browser/gues... File extensions/browser/guest_view/mime_handler_view/mime_handler_stream_manager.cc (right): https://codereview.chromium.org/2652903002/diff/40001/extensions/browser/gues... extensions/browser/guest_view/mime_handler_view/mime_handler_stream_manager.cc:208: !IsTrackedRenderFrameHost(navigation_handle->GetRenderFrameHost())) nit: {}
https://codereview.chromium.org/2652903002/diff/40001/extensions/browser/gues... File extensions/browser/guest_view/mime_handler_view/mime_handler_stream_manager.cc (right): https://codereview.chromium.org/2652903002/diff/40001/extensions/browser/gues... extensions/browser/guest_view/mime_handler_view/mime_handler_stream_manager.cc:208: !IsTrackedRenderFrameHost(navigation_handle->GetRenderFrameHost())) On 2017/01/24 23:22:14, lazyboy wrote: > nit: {} Done.
The CQ bit was checked by jam@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from lazyboy@chromium.org Link to the patchset: https://codereview.chromium.org/2652903002/#ps60001 (title: "nit")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1485301195894100,
"parent_rev": "9257ae440105ca90bd219517782cf55258fc830c", "commit_rev":
"34daea6e90246c16505840ff3d75991ef34e8a2d"}
Message was sent while issue was closed.
Description was changed from ========== Convert MimeHandlerStreamManager to use the new navigation callbacks. BUG=682002 ========== to ========== Convert MimeHandlerStreamManager to use the new navigation callbacks. BUG=682002 Review-Url: https://codereview.chromium.org/2652903002 Cr-Commit-Position: refs/heads/master@{#445884} Committed: https://chromium.googlesource.com/chromium/src/+/34daea6e90246c16505840ff3d75... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as https://chromium.googlesource.com/chromium/src/+/34daea6e90246c16505840ff3d75... |
