Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 2652893010: Interpreter tester should accept metadata instead of a vector (Closed)

Created:
3 years, 11 months ago by mvstanton
Modified:
3 years, 11 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Interpreter tester should accept metadata instead of a vector The InterpreterTester class cobbles together a JSFunction from a manually created bytecode and feedback vector. However it's fragile against design changes in the way literal arrays and feedback vectors are handled. It's better to let it hand in a feedback vector metadata object, and allow the system to create the vector from that. BUG=v8:5456 Review-Url: https://codereview.chromium.org/2652893010 Cr-Commit-Position: refs/heads/master@{#42684} Committed: https://chromium.googlesource.com/v8/v8/+/d24ce605c99f5b45e596e88931127d6ce6d0d27a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -153 lines) Patch
M test/cctest/interpreter/interpreter-tester.h View 4 chunks +13 lines, -7 lines 0 comments Download
M test/cctest/interpreter/interpreter-tester.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 42 chunks +133 lines, -141 lines 0 comments Download
M test/cctest/test-feedback-vector.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
mvstanton
Hi Ross, Here is the CL I mentioned, thanks! --Michael
3 years, 11 months ago (2017-01-26 09:29:58 UTC) #2
rmcilroy
LGTM, thanks
3 years, 11 months ago (2017-01-26 09:34:15 UTC) #5
rmcilroy
LGTM, thanks
3 years, 11 months ago (2017-01-26 09:34:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652893010/1
3 years, 11 months ago (2017-01-26 09:36:12 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 10:03:06 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d24ce605c99f5b45e596e88931127d6ce6d...

Powered by Google App Engine
This is Rietveld 408576698