Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2652893006:
Releases DiskCacheBasedQuicServerInfo::|new_data_| and |pending_write_data_| (Closed)
|
Created:
3 years, 11 months ago by xunjieli Modified:
3 years, 11 months ago Reviewers:
Ryan Hamilton CC:
chromium-reviews, cbentzel+watch_chromium.org, wtc Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionReleases DiskCacheBasedQuicServerInfo::|new_data_| and |pending_write_data_|
std::string::clear() doesn't deallocate memory, so the ~8KiB*2 memory
taken by |new_data_| and |pending_write_data_| can be around for quite
a while (until QuicChromiumClientStream is torn down).
This CL deallocate |new_data_| and |pending_write_data_| when they
are no longer needed.
BUG=684746
Review-Url: https://codereview.chromium.org/2652893006
Cr-Commit-Position: refs/heads/master@{#445918}
Committed: https://chromium.googlesource.com/chromium/src/+/811b298ca853197b54a6a2bbeefcccdcb9ee98aa
Patch Set 1 : self review #Patch Set 2 : use STLClearObject instead #Messages
Total messages: 18 (12 generated)
Description was changed from ========== Releases DiskCacheBasedQuicServerInfo::|new_data_| std::string::clear() doesn't deallocate memory, so the ~8Kib memory taken by |new_data_| can be around for quite a while (until Quic session is torn down). This CL deallocate |new_data_| when it's no longer needed. BUG=684746 ========== to ========== Releases DiskCacheBasedQuicServerInfo::|new_data_| and |pending_write_data_| std::string::clear() doesn't deallocate memory, so the ~8Kib memory taken by |new_data_| and |pending_write_data_| can be around for quite a while (until Quic session is torn down). This CL deallocate |new_data_| when it's no longer needed. BUG=684746 ==========
Patchset #1 (id:1) has been deleted
Description was changed from ========== Releases DiskCacheBasedQuicServerInfo::|new_data_| and |pending_write_data_| std::string::clear() doesn't deallocate memory, so the ~8Kib memory taken by |new_data_| and |pending_write_data_| can be around for quite a while (until Quic session is torn down). This CL deallocate |new_data_| when it's no longer needed. BUG=684746 ========== to ========== Releases DiskCacheBasedQuicServerInfo::|new_data_| and |pending_write_data_| std::string::clear() doesn't deallocate memory, so the ~8KiB*2 memory taken by |new_data_| and |pending_write_data_| can be around for quite a while (until Quic session is torn down). This CL deallocate |new_data_| and |pending_write_data_| when they are no longer needed. BUG=684746 ==========
Description was changed from ========== Releases DiskCacheBasedQuicServerInfo::|new_data_| and |pending_write_data_| std::string::clear() doesn't deallocate memory, so the ~8KiB*2 memory taken by |new_data_| and |pending_write_data_| can be around for quite a while (until Quic session is torn down). This CL deallocate |new_data_| and |pending_write_data_| when they are no longer needed. BUG=684746 ========== to ========== Releases DiskCacheBasedQuicServerInfo::|new_data_| and |pending_write_data_| std::string::clear() doesn't deallocate memory, so the ~8KiB*2 memory taken by |new_data_| and |pending_write_data_| can be around for quite a while (until QuicChromiumClientStream is torn down). This CL deallocate |new_data_| and |pending_write_data_| when they are no longer needed. BUG=684746 ==========
xunjieli@chromium.org changed reviewers: + rch@chromium.org
Ryan, PTAL. Thanks!
On 2017/01/24 22:21:36, xunjieli wrote: Thanks xunjieli@ for fixing this.
The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm Thanks for doing this!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
The CQ bit was checked by xunjieli@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485309606720670,
"parent_rev": "7b638658485d09fb68411aa0576ca41c9d330146", "commit_rev":
"811b298ca853197b54a6a2bbeefcccdcb9ee98aa"}
Message was sent while issue was closed.
Description was changed from ========== Releases DiskCacheBasedQuicServerInfo::|new_data_| and |pending_write_data_| std::string::clear() doesn't deallocate memory, so the ~8KiB*2 memory taken by |new_data_| and |pending_write_data_| can be around for quite a while (until QuicChromiumClientStream is torn down). This CL deallocate |new_data_| and |pending_write_data_| when they are no longer needed. BUG=684746 ========== to ========== Releases DiskCacheBasedQuicServerInfo::|new_data_| and |pending_write_data_| std::string::clear() doesn't deallocate memory, so the ~8KiB*2 memory taken by |new_data_| and |pending_write_data_| can be around for quite a while (until QuicChromiumClientStream is torn down). This CL deallocate |new_data_| and |pending_write_data_| when they are no longer needed. BUG=684746 Review-Url: https://codereview.chromium.org/2652893006 Cr-Commit-Position: refs/heads/master@{#445918} Committed: https://chromium.googlesource.com/chromium/src/+/811b298ca853197b54a6a2bbeefc... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/chromium/src/+/811b298ca853197b54a6a2bbeefc... |
