Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2652853002: Remove unnecessary uses of build_overrides/v8.gni. (Closed)

Created:
3 years, 11 months ago by brettw
Modified:
3 years, 11 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, jochen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary uses of build_overrides/v8.gni. I think this file used to have more stuff in it like v8_use_external_startup_data. This flag has now moved to v8/gni/v8.gni. BUG=684096 Review-Url: https://codereview.chromium.org/2652853002 Cr-Commit-Position: refs/heads/master@{#445584} Committed: https://chromium.googlesource.com/chromium/src/+/7b20d2e9e9113b3ad2ee1db858e8d16d2b947058

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
brettw
3 years, 11 months ago (2017-01-23 22:17:15 UTC) #3
Dirk Pranke
lgtm
3 years, 11 months ago (2017-01-23 22:50:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652853002/1
3 years, 11 months ago (2017-01-24 00:14:09 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 01:44:22 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7b20d2e9e9113b3ad2ee1db858e8...

Powered by Google App Engine
This is Rietveld 408576698