Define ADDRESS_SANITIZER whenever ASan is used

Define ADDRESS_SANITIZER whenever ASan is used

Also, fix SecurityTest.CallocOverflow under ASan/Win

BUG=345874
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268690

[Timur Iskhodzhanov, 2014-05-06 13:14:52]

Alexander, Julien,

Can you please review this small patch?

Julien -- please look at the base/ part
Alexander -- please look at the build/ part and sanity-check the generalization.

[CC Hans and Eugeniy just FYI]

--
Thanks,
Timur

[Alexander Potapenko, 2014-05-06 13:22:11]

What you're doing sounds more like "enable SecurityTest.CallocOverflow under
ASan/Win", not "fix".

Please also move MEMORY_TOOL_REPLACES_ALLOCATOR to the same place.

[Timur Iskhodzhanov, 2014-05-06 13:39:51]

>
> What you're doing sounds more like "enable SecurityTest.CallocOverflow
> under
> ASan/Win", not "fix".
>

As we've discussed offline, this indeed fixes the test under ASan/Win.


> Please also move MEMORY_TOOL_REPLACES_ALLOCATOR to the same place.
>

Done, PTAL

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Alexander Potapenko, 2014-05-06 13:41:39]

LGTM, but please run ASan trybots before landing

(Timur explained me this is essentially a fix since the test was crashing)

[jln (very slow on Chromium), 2014-05-06 20:03:59]

On 2014/05/06 13:41:39, Alexander Potapenko wrote:
> LGTM, but please run ASan trybots before landing
> 
> (Timur explained me this is essentially a fix since the test was crashing)

base/security_unittest.cc lgtm as long as try bots are happy. I launched a win64
bot as well.

[Timur Iskhodzhanov, 2014-05-07 08:19:35]

The CQ bit was checked by timurrrr@chromium.org

[commit-bot: I haz the power, 2014-05-07 08:20:35]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/timurrrr@chromium.org/265283009/20001

[commit-bot: I haz the power, 2014-05-07 08:57:50]

Change committed as 268690

[Timur Iskhodzhanov, 2014-05-07 09:37:40]

Thanks!

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.