Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(870)

Unified Diff: build/common.gypi

Issue 265283009: Define ADDRESS_SANITIZER whenever ASan is used (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address glider@'s comment Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/security_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index f47987633bc652221139f563b0aa35604d40a871..761a415b8748c01541eedd511b7f4ef69a890180 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -2502,6 +2502,12 @@
'ENABLE_EGLIMAGE=1',
],
}],
+ ['asan==1', {
+ 'defines': [
+ 'ADDRESS_SANITIZER',
+ 'MEMORY_TOOL_REPLACES_ALLOCATOR',
+ ],
+ }],
['syzyasan==1', {
# SyzyAsan needs /PROFILE turned on to produce appropriate pdbs.
'msvs_settings': {
@@ -3715,9 +3721,6 @@
'ldflags': [
'-fsanitize=address',
],
- 'defines': [
- 'ADDRESS_SANITIZER',
- ],
}],
],
'conditions': [
@@ -4450,10 +4453,6 @@
'-w', # http://crbug.com/162783
],
},
- 'defines': [
- 'ADDRESS_SANITIZER',
- 'MEMORY_TOOL_REPLACES_ALLOCATOR',
- ],
}],
['asan_coverage!=0', {
'target_conditions': [
« no previous file with comments | « base/security_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698