Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 2652823004: Roll ios toolchain to 8.2.1. (Closed)

Created:
3 years, 11 months ago by justincohen
Modified:
3 years, 11 months ago
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll ios toolchain to 8.2.1. BUG= Review-Url: https://codereview.chromium.org/2652823004 Cr-Commit-Position: refs/heads/master@{#446357} Committed: https://chromium.googlesource.com/chromium/src/+/3c4d50886437cc67b8e71485b478d835bc672c0d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/mac_toolchain.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 26 (13 generated)
justincohen
needs a tracking bug, but otherwise ptal
3 years, 11 months ago (2017-01-24 21:52:09 UTC) #2
rohitrao (ping after 24h)
Will this CL break the bots if we're still hard-coding the 10.0 SDK?
3 years, 11 months ago (2017-01-24 21:53:56 UTC) #5
justincohen
We actually were running in 8.2 (not 8.2.1) for a few weeks before rolling back ...
3 years, 11 months ago (2017-01-24 21:56:29 UTC) #7
justincohen
Looks like it's building correctly downstream, e.g.: export DEVELOPER_DIR=<snip>/ios_files/Xcode.app; <snip> -DCR_XCODE_VERSION=0821 <snip> -isysroot <snip>src/build/ios_files/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator10.2.sdk
3 years, 11 months ago (2017-01-24 22:12:50 UTC) #8
smut
On 2017/01/24 21:56:29, justincohen wrote: > smut@ what happens when the requested sdk isn't available? ...
3 years, 11 months ago (2017-01-24 23:05:09 UTC) #9
justincohen
smut@ any objections to this roll?
3 years, 11 months ago (2017-01-25 17:03:33 UTC) #12
smut
lgtm
3 years, 11 months ago (2017-01-25 22:11:21 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652823004/1
3 years, 11 months ago (2017-01-25 22:40:35 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/220328)
3 years, 11 months ago (2017-01-26 00:20:57 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652823004/1
3 years, 11 months ago (2017-01-26 00:30:50 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/220583)
3 years, 11 months ago (2017-01-26 03:57:57 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652823004/1
3 years, 11 months ago (2017-01-26 16:17:04 UTC) #23
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 16:56:35 UTC) #26
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3c4d50886437cc67b8e71485b478...

Powered by Google App Engine
This is Rietveld 408576698