|
|
Created:
3 years, 11 months ago by justincohen Modified:
3 years, 11 months ago CC:
chromium-reviews, mac-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll ios toolchain to 8.2.1.
BUG=
Review-Url: https://codereview.chromium.org/2652823004
Cr-Commit-Position: refs/heads/master@{#446357}
Committed: https://chromium.googlesource.com/chromium/src/+/3c4d50886437cc67b8e71485b478d835bc672c0d
Patch Set 1 #
Messages
Total messages: 26 (13 generated)
justincohen@chromium.org changed reviewers: + rohitrao@chromium.org
needs a tracking bug, but otherwise ptal
The CQ bit was checked by justincohen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Will this CL break the bots if we're still hard-coding the 10.0 SDK?
justincohen@chromium.org changed reviewers: + smut@google.com
We actually were running in 8.2 (not 8.2.1) for a few weeks before rolling back and had no issues. smut@ what happens when the requested sdk isn't available? i'm assuming it uses what is available. the results of find_xcode are ignored in hermetic builds.
Looks like it's building correctly downstream, e.g.: export DEVELOPER_DIR=<snip>/ios_files/Xcode.app; <snip> -DCR_XCODE_VERSION=0821 <snip> -isysroot <snip>src/build/ios_files/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator10.2.sdk
On 2017/01/24 21:56:29, justincohen wrote: > smut@ what happens when the requested sdk isn't available? We don't look at the SDK at all anymore in infra scripts since hermetic was enabled, so whatever hermetic does when it's not available is what will happen.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
smut@ any objections to this roll?
lgtm
The CQ bit was checked by justincohen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by smut@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by justincohen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1485447402401660, "parent_rev": "027ca1e1259f228e14ad253169ef0263963122fe", "commit_rev": "3c4d50886437cc67b8e71485b478d835bc672c0d"}
Message was sent while issue was closed.
Description was changed from ========== Roll ios toolchain to 8.2.1. BUG= ========== to ========== Roll ios toolchain to 8.2.1. BUG= Review-Url: https://codereview.chromium.org/2652823004 Cr-Commit-Position: refs/heads/master@{#446357} Committed: https://chromium.googlesource.com/chromium/src/+/3c4d50886437cc67b8e71485b478... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/3c4d50886437cc67b8e71485b478... |