Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2652793004: [x64] Fix REX prefix in shufps (Closed)

Created:
3 years, 11 months ago by Jing
Modified:
3 years, 11 months ago
Reviewers:
bbudge
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[x64] Fix REX prefix in shufps BUG= Review-Url: https://codereview.chromium.org/2652793004 Cr-Commit-Position: refs/heads/master@{#42673} Committed: https://chromium.googlesource.com/v8/v8/+/d28c04486bd5c415748cd00f5c21c92fb35dd025

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/x64/assembler-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-disasm-x64.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Jing
Hi, x64 assembler currently emits a wrong REX prefix for shufps instruction. This is a ...
3 years, 11 months ago (2017-01-25 05:33:35 UTC) #2
bbudge
lgtm
3 years, 11 months ago (2017-01-25 15:26:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652793004/1
3 years, 11 months ago (2017-01-26 01:36:24 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 01:38:26 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d28c04486bd5c415748cd00f5c21c92fb35...

Powered by Google App Engine
This is Rietveld 408576698