Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1044)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2652783002: Mojo C++ bindings: add a "deprecated" comment to type_converter.h (Closed)

Created:
3 years, 11 months ago by yzshen1
Modified:
3 years, 11 months ago
Reviewers:
scheib
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: add a "deprecated" comment to type_converter.h BUG=621383 Review-Url: https://codereview.chromium.org/2652783002 Cr-Commit-Position: refs/heads/master@{#445455} Committed: https://chromium.googlesource.com/chromium/src/+/b5c04f866115e2e1040d8f09fa34732ccbec54b3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M mojo/public/cpp/bindings/type_converter.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
yzshen1
Hi, Vincent. PTAL. Thanks!
3 years, 11 months ago (2017-01-23 18:24:27 UTC) #2
scheib
lgtm
3 years, 11 months ago (2017-01-23 18:32:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652783002/1
3 years, 11 months ago (2017-01-23 18:33:25 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 20:12:10 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b5c04f866115e2e1040d8f09fa34...

Powered by Google App Engine
This is Rietveld 408576698