Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2652763013: Cleanup: Remove the last traces of Instant Search on Android (Closed)

Created:
3 years, 11 months ago by Marc Treib
Modified:
3 years, 10 months ago
Reviewers:
Ted C
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove the last traces of Instant Search on Android - Usage of InstantSearchPrerenderer in omnibox_prerender.cc. - Some unnecessary includes in toolbar_model_android.cc. Instant was never launched on Android; it's time to get rid of the code. BUG=627747 Review-Url: https://codereview.chromium.org/2652763013 Cr-Commit-Position: refs/heads/master@{#446355} Committed: https://chromium.googlesource.com/chromium/src/+/eae6137965dceb05f01056f60f9ae6c95cd3cd12

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -33 lines) Patch
M chrome/browser/android/omnibox/omnibox_prerender.cc View 3 chunks +8 lines, -28 lines 0 comments Download
M chrome/browser/ui/android/toolbar/toolbar_model_android.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Marc Treib
PTAL!
3 years, 11 months ago (2017-01-26 09:24:07 UTC) #8
Ted C
lgtm
3 years, 10 months ago (2017-01-26 16:42:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652763013/1
3 years, 10 months ago (2017-01-26 16:45:48 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-01-26 16:51:32 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/eae6137965dceb05f01056f60f9a...

Powered by Google App Engine
This is Rietveld 408576698