Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 2652763010: [turbofan] Constant-fold JSGetSuperConstructor. (Closed)

Created:
3 years, 11 months ago by Benedikt Meurer
Modified:
3 years, 11 months ago
Reviewers:
petermarshall
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Constant-fold JSGetSuperConstructor. This adds support to constant-fold JSGetSuperConstructor(constructor) for constructors with stable maps, i.e. where we can add a stability dependency on the constructors map to get notified when the [[Prototype]] of constructor changes. R=petermarshall@chromium.org BUG=v8:5517 Review-Url: https://codereview.chromium.org/2652763010 Cr-Commit-Position: refs/heads/master@{#42647} Committed: https://chromium.googlesource.com/v8/v8/+/d0a24e913f6653531786bc237793fdb0e7ebfa53

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -0 lines) Patch
M src/compiler/js-native-context-specialization.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 2 chunks +37 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Benedikt Meurer
3 years, 11 months ago (2017-01-25 06:41:59 UTC) #1
Benedikt Meurer
Hey Peter, Here's a simple optimization for the common case of GetSuperConstructor in subclasses. We ...
3 years, 11 months ago (2017-01-25 06:45:23 UTC) #4
petermarshall
LGTM! You might need owners approval from someone else though, not sure.
3 years, 11 months ago (2017-01-25 08:32:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652763010/1
3 years, 11 months ago (2017-01-25 08:46:33 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 08:48:54 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d0a24e913f6653531786bc237793fdb0e7e...

Powered by Google App Engine
This is Rietveld 408576698