Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1221)

Issue 2652763008: Fix constructor call (Closed)

Created:
3 years, 10 months ago by hans
Modified:
3 years, 10 months ago
Reviewers:
Reid Kleckner, xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix constructor call The expression was referring directly to the constructor, but it needs to refer to the type. New versions of Clang started erroring on this (see bug). BUG=684590 Review-Url: https://codereview.chromium.org/2652763008 Cr-Commit-Position: refs/heads/master@{#445839} Committed: https://chromium.googlesource.com/chromium/src/+/07a0b4579f2dcae5f9d02d5b78fc3b8f79bf1f6d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/cert/x509_certificate_mac.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
hans
Please take a look.
3 years, 10 months ago (2017-01-24 20:43:09 UTC) #2
Reid Kleckner
lgtm
3 years, 10 months ago (2017-01-24 21:05:05 UTC) #3
xunjieli
lgtm
3 years, 10 months ago (2017-01-24 21:19:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652763008/1
3 years, 10 months ago (2017-01-24 21:29:29 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-01-24 22:23:07 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/07a0b4579f2dcae5f9d02d5b78fc...

Powered by Google App Engine
This is Rietveld 408576698