Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2652763007: Send site certificate chain to android payment app (Closed)

Created:
3 years, 11 months ago by rwlbuis
Modified:
3 years, 11 months ago
CC:
chromium-reviews, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org, gogerald+paymentswatch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Send site certificate chain to android payment app Send site certificate chain of the top-level browsing context to android payment app as described in the specification: https://docs.google.com/document/d/1izV4uC-tiRJG3JLooqY3YRLU22tYOsLTNq0P_InPJeE BUG=620173 Review-Url: https://codereview.chromium.org/2652763007 Cr-Commit-Position: refs/heads/master@{#446051} Committed: https://chromium.googlesource.com/chromium/src/+/6e547f0c061ed010efd6ee9e5166c327a92eba7a

Patch Set 1 #

Patch Set 2 : Fix compilation #

Patch Set 3 : Test #

Patch Set 4 : Probable fix #

Total comments: 2

Patch Set 5 : Actually call getCertificateChain #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -32 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java View 5 chunks +19 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentApp.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentApp.java View 1 chunk +8 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentInstrument.java View 1 chunk +13 lines, -12 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java View 3 4 5 chunks +7 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentApp.java View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentInstrument.java View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/android/page_info/certificate_chain_helper.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
rwlbuis
PTAL.
3 years, 11 months ago (2017-01-24 21:53:50 UTC) #4
please use gerrit instead
I like this approach :-) https://codereview.chromium.org/2652763007/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java File chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java (right): https://codereview.chromium.org/2652763007/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java#newcode303 chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java:303: mCertificateChain = null; Need ...
3 years, 11 months ago (2017-01-25 15:39:12 UTC) #5
rwlbuis
https://codereview.chromium.org/2652763007/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java File chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java (right): https://codereview.chromium.org/2652763007/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java#newcode303 chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java:303: mCertificateChain = null; On 2017/01/25 15:39:12, rouslan wrote: > ...
3 years, 11 months ago (2017-01-25 15:49:40 UTC) #6
please use gerrit instead
lgtm
3 years, 11 months ago (2017-01-25 15:53:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652763007/80001
3 years, 11 months ago (2017-01-25 16:53:03 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/350019)
3 years, 11 months ago (2017-01-25 17:00:52 UTC) #11
rwlbuis
+tedchoc for certificate_chain_helper.cc review.
3 years, 11 months ago (2017-01-25 17:04:18 UTC) #13
Ted C
On 2017/01/25 17:04:18, rwlbuis wrote: > +tedchoc for certificate_chain_helper.cc review. certificate_chain_helper.cc - lgtm
3 years, 11 months ago (2017-01-25 17:19:49 UTC) #14
rwlbuis
On 2017/01/25 17:19:49, Ted C wrote: > On 2017/01/25 17:04:18, rwlbuis wrote: > > +tedchoc ...
3 years, 11 months ago (2017-01-25 17:37:32 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652763007/80001
3 years, 11 months ago (2017-01-25 17:38:13 UTC) #17
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 17:43:56 UTC) #20
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/6e547f0c061ed010efd6ee9e5166...

Powered by Google App Engine
This is Rietveld 408576698