Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Issue 2652763002: ash: removes unnecessary includes and dep (Closed)

Created:
3 years, 11 months ago by sky
Modified:
3 years, 11 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ash: removes unnecessary includes and dep BUG=670798 TEST=none R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2652763002 Cr-Commit-Position: refs/heads/master@{#445470} Committed: https://chromium.googlesource.com/chromium/src/+/2ba6bc624e1a29ebe9fa66c36cc96e16224c858a

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M ash/BUILD.gn View 1 chunk +0 lines, -4 lines 2 comments Download
M ash/common/cast_config_controller.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
sky
3 years, 11 months ago (2017-01-23 17:17:46 UTC) #1
James Cook
LGTM https://codereview.chromium.org/2652763002/diff/1/ash/BUILD.gn File ash/BUILD.gn (left): https://codereview.chromium.org/2652763002/diff/1/ash/BUILD.gn#oldcode862 ash/BUILD.gn:862: "//content/public/common:service_names", Per offline discussion, can you ping ben ...
3 years, 11 months ago (2017-01-23 17:25:05 UTC) #2
sky
https://codereview.chromium.org/2652763002/diff/1/ash/BUILD.gn File ash/BUILD.gn (left): https://codereview.chromium.org/2652763002/diff/1/ash/BUILD.gn#oldcode862 ash/BUILD.gn:862: "//content/public/common:service_names", On 2017/01/23 17:25:05, James Cook wrote: > Per ...
3 years, 11 months ago (2017-01-23 17:27:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652763002/1
3 years, 11 months ago (2017-01-23 17:28:10 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/368905)
3 years, 11 months ago (2017-01-23 17:30:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652763002/1
3 years, 11 months ago (2017-01-23 19:29:15 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 20:36:07 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2ba6bc624e1a29ebe9fa66c36cc9...

Powered by Google App Engine
This is Rietveld 408576698