Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2652573002: Close browser RouterProvider binding on renderer death (Closed)

Created:
3 years, 11 months ago by tibell
Modified:
3 years, 11 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, nasko+codewatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Close browser RouterProvider binding on renderer death BUG=683794 Review-Url: https://codereview.chromium.org/2652573002 Cr-Commit-Position: refs/heads/master@{#445523} Committed: https://chromium.googlesource.com/chromium/src/+/4d9f1c2e1cf7a167d2e0737692b18e5e68cbe71b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
tibell
Found this one while debugging http://crbug.com/683021 together with Sam.
3 years, 11 months ago (2017-01-23 04:03:53 UTC) #2
jam
lgtm
3 years, 11 months ago (2017-01-23 16:57:12 UTC) #7
Ken Rockot(use gerrit already)
lgtm
3 years, 11 months ago (2017-01-23 17:43:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652573002/1
3 years, 11 months ago (2017-01-23 22:40:28 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 22:47:07 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4d9f1c2e1cf7a167d2e0737692b1...

Powered by Google App Engine
This is Rietveld 408576698