[Android Webapps] Remove checking for live WebappManagedActivities on L+

[Android Webapps] Remove checking for live WebappManagedActivities on L+

As of https://codereview.chromium.org/1354323003 WebappManagedActivities are not
created on L+

BUG=646608
`

Review-Url: https://codereview.chromium.org/2652523002
Cr-Commit-Position: refs/heads/master@{#484929}
Committed: https://chromium.googlesource.com/chromium/src/+/5b096435a17f5178886a0e3adac0f994d8520efe

[pkotwicz, 2017-01-22 02:00:02]

pkotwicz@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[pkotwicz, 2017-01-22 02:00:02]

Dan can you please take a look?

[gone, 2017-01-23 19:19:09]

Er, the point of this code was to clean up directories that were created pre-L
after they upgraded to L—it says that in the function Javadoc.  It wasn't to
check for live WebappManagedActivities.

I'm fine with making this code run once and storing a SharedPref (and can
probably be convinced to get rid of the code entirely), but I'd like to
understand your thought process.

[pkotwicz, 2017-07-06 17:46:30]

Patchset #2 (id:20001) has been deleted

[pkotwicz, 2017-07-06 17:48:07]

pkotwicz@chromium.org changed reviewers:
+ yfriedman@chromium.org
- dfalcantara@chromium.org

[pkotwicz, 2017-07-06 17:48:08]

Yaron, can you please take a look? I think that this CL makes sense because
findStaleWebappDirectories() is only run on L+

[Yaron, 2017-07-06 18:47:17]

On 2017/07/06 17:48:08, pkotwicz wrote:
> Yaron, can you please take a look? I think that this CL makes sense because
> findStaleWebappDirectories() is only run on L+

Dan's point was valid though - this cleans up user's data if they were using
webapps pre-L and then got updated to L.
It's decreasingly likely that's the case though (and there's no harm other than
a tiny bit of disk space) so I'm not strictly opposed but would at least want
the comments cleaned up

[pkotwicz, 2017-07-06 19:29:27]

My CL only affects the logic to delete:
"directories corresponding to WebappActivities that are no longer listed in
Android's recents, since these will be unable to restore their data."

Note that findStaleWebappDirectories() has two roles one of which is deleting
the "pre-L directory structure". This CL does not affect that

In fact, this CL will result in more directories getting deleted not less
directories getting deleted

[Yaron, 2017-07-07 14:18:10]

right. thanks for explanation. lgtm

[pkotwicz, 2017-07-07 14:22:34]

Description was changed from

==========
Remove checking for live WebappManagedActivities on L+

As of https://codereview.chromium.org/1354323003 WebappManagedActivities are not
created on L+

BUG=646608`
==========

to

==========
[Android Webapps] Remove checking for live WebappManagedActivities on L+

As of https://codereview.chromium.org/1354323003 WebappManagedActivities are not
created on L+

BUG=646608`
==========

[pkotwicz, 2017-07-07 14:23:07]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2017-07-07 14:23:15]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-07 15:15:40]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1499437387334770,
"parent_rev": "520115400d66bb2988b0ba8dcfa12397b9f1af2a", "commit_rev":
"5b096435a17f5178886a0e3adac0f994d8520efe"}

[commit-bot: I haz the power, 2017-07-07 15:15:50]

Description was changed from

==========
[Android Webapps] Remove checking for live WebappManagedActivities on L+

As of https://codereview.chromium.org/1354323003 WebappManagedActivities are not
created on L+

BUG=646608`
==========

to

==========
[Android Webapps] Remove checking for live WebappManagedActivities on L+

As of https://codereview.chromium.org/1354323003 WebappManagedActivities are not
created on L+

BUG=646608`

Review-Url: https://codereview.chromium.org/2652523002
Cr-Commit-Position: refs/heads/master@{#484929}
Committed:
https://chromium.googlesource.com/chromium/src/+/5b096435a17f5178886a0e3adac0...
==========

[commit-bot: I haz the power, 2017-07-07 15:15:52]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5b096435a17f5178886a0e3adac0...