Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2652463002: Upstream IDBCursor.continuePrimaryKey exception test to WPT. (Closed)

Created:
3 years, 11 months ago by pwnall
Modified:
3 years, 11 months ago
Reviewers:
jsbell, jeffcarp
CC:
chromium-reviews, blink-reviews, jsbell+idb_chromium.org, cmumford
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream IDBCursor.continuePrimaryKey exception test to WPT. BUG=683463 Review-Url: https://codereview.chromium.org/2652463002 Cr-Commit-Position: refs/heads/master@{#445616} Committed: https://chromium.googlesource.com/chromium/src/+/9b6df1c9b6a261fcc2a26a4471e54c7f421b5cb8

Patch Set 1 : Renamed .html to .htm, to match other files in the directory. #

Patch Set 2 : third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/manifest --work --tests-root=third_par… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -101 lines) Patch
A + third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbcursor-continuePrimaryKey-exceptions.htm View 1 chunk +7 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/MANIFEST.json View 1 3 chunks +11 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/storage/indexeddb/idbcursor_continueprimarykey.html View 1 chunk +0 lines, -96 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
pwnall
jsbell: Can you please review the test content? jeffcarp: Can you please check that I've ...
3 years, 11 months ago (2017-01-23 22:46:46 UTC) #11
jsbell
test LGTM no idea about MANIFEST.json; given that it's a *generated* file on the WPT ...
3 years, 11 months ago (2017-01-24 00:28:18 UTC) #12
pwnall
On 2017/01/24 00:28:18, jsbell wrote: > test LGTM > > no idea about MANIFEST.json; given ...
3 years, 11 months ago (2017-01-24 00:34:41 UTC) #13
jeffcarp
On 2017/01/24 at 00:34:41, pwnall wrote: > On 2017/01/24 00:28:18, jsbell wrote: > > test ...
3 years, 11 months ago (2017-01-24 01:34:07 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652463002/40001
3 years, 11 months ago (2017-01-24 01:39:42 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/chromium/src/+/9b6df1c9b6a261fcc2a26a4471e54c7f421b5cb8
3 years, 11 months ago (2017-01-24 02:42:21 UTC) #19
jeffcarp
3 years, 11 months ago (2017-01-24 03:08:55 UTC) #20
Message was sent while issue was closed.
On 2017/01/24 at 02:42:21, commit-bot wrote:
> Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9b6df1c9b6a261fcc2a26a4471e5...

Upstreamed: https://github.com/w3c/web-platform-tests/pull/4607

Powered by Google App Engine
This is Rietveld 408576698