Convert CrossSiteRedirectorBrowserTest to use the new navigation callbacks.

Convert CrossSiteRedirectorBrowserTest to use the new navigation callbacks.

BUG=682002
Review-Url: https://codereview.chromium.org/2652413003
Cr-Commit-Position: refs/heads/master@{#446516}
Committed: https://chromium.googlesource.com/chromium/src/+/a43bf0c840d6d4c573e3847e4359698f61920978

[jam, 2017-01-26 22:28:31]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[jam, 2017-01-26 22:28:50]

Description was changed from

==========
Convert CrossSiteRedirectorBrowserTest to use the new navigation callbacks.

BUG=682002
==========

to

==========
Convert CrossSiteRedirectorBrowserTest to use the new navigation callbacks.

BUG=682002
==========

[jam, 2017-01-26 22:28:50]

jam@chromium.org changed reviewers:
+ nasko@chromium.org

[commit-bot: I haz the power, 2017-01-26 22:29:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 23:22:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 23:22:37]

Dry run: This issue passed the CQ dry run.

[nasko, 2017-01-27 00:25:07]

LGTM

https://codereview.chromium.org/2652413003/diff/1/content/test/browser_test_u...
File content/test/browser_test_utils_browsertest.cc (right):

https://codereview.chromium.org/2652413003/diff/1/content/test/browser_test_u...
content/test/browser_test_utils_browsertest.cc:24: if
(navigation_handle->HasCommitted())
Should we use the same approach as the other CL to check it isn't an error?

[jam, 2017-01-27 00:37:08]

https://codereview.chromium.org/2652413003/diff/1/content/test/browser_test_u...
File content/test/browser_test_utils_browsertest.cc (right):

https://codereview.chromium.org/2652413003/diff/1/content/test/browser_test_u...
content/test/browser_test_utils_browsertest.cc:24: if
(navigation_handle->HasCommitted())
On 2017/01/27 00:25:07, nasko wrote:
> Should we use the same approach as the other CL to check it isn't an error?

since
1) it doesn't matter in this case since it's a test, and it's still passing
2) the old callback would get called for the error url and it wasn't checking
that
I left it out

[jam, 2017-01-27 00:37:13]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2017-01-27 00:38:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 01:13:37]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485477433910460, "parent_rev":
"b5c8d0d1bed4056880ad70ed949714f9edc0f81b", "commit_rev":
"a43bf0c840d6d4c573e3847e4359698f61920978"}

[commit-bot: I haz the power, 2017-01-27 01:14:07]

Description was changed from

==========
Convert CrossSiteRedirectorBrowserTest to use the new navigation callbacks.

BUG=682002
==========

to

==========
Convert CrossSiteRedirectorBrowserTest to use the new navigation callbacks.

BUG=682002

Review-Url: https://codereview.chromium.org/2652413003
Cr-Commit-Position: refs/heads/master@{#446516}
Committed:
https://chromium.googlesource.com/chromium/src/+/a43bf0c840d6d4c573e3847e4359...
==========

[commit-bot: I haz the power, 2017-01-27 01:14:08]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a43bf0c840d6d4c573e3847e4359...