Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 2652393005: Suppress NEW_NAVIGATION_ENTRY prerenderer failures for ORIGIN_OFFLINE (Closed)

Created:
3 years, 10 months ago by Pete Williamson
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Suppress NEW_NAVIGATION_ENTRY prerenderer failures for ORIGIN_OFFLINE We have noticed some FINAL_STATUS_NEW_NAVIGATION_ENTRY failures in UMA for offline pages but didn't know how to trigger them. Bug 675767 has identified a site (foxsports.com) with articles/links that do have this issue. The issue is repeatable for those pages and they are never succeeding. I end-to-end tested this change with logging to confirm we do repeatably see entry count going to 2 and that with this change the pages can background load successfully. BUG=675767 Review-Url: https://codereview.chromium.org/2656653002 Cr-Commit-Position: refs/heads/master@{#446379} (cherry picked from commit 3ae6f734f3566484634a068cbe663bbccc24937c) Review-Url: https://codereview.chromium.org/2652393005 . Cr-Commit-Position: refs/branch-heads/2987@{#159} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/31f17d1b0f90bf0ed092d3b620b4d2434e20d14b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -0 lines) Patch
M chrome/browser/prerender/prerender_browsertest.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M chrome/browser/prerender/prerender_contents.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Pete Williamson
3 years, 10 months ago (2017-01-27 22:57:56 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
31f17d1b0f90bf0ed092d3b620b4d2434e20d14b.

Powered by Google App Engine
This is Rietveld 408576698