Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issue 2652393003: [Sync] MergeSyncData implementation for Autocomplete. (Closed)

Created:
3 years, 11 months ago by skym
Modified:
3 years, 10 months ago
Reviewers:
Mathieu, Patrick Noland
CC:
chromium-reviews, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, mathp+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] MergeSyncData implementation for Autocomplete. BUG=680218 Review-Url: https://codereview.chromium.org/2652393003 Cr-Commit-Position: refs/heads/master@{#447266} Committed: https://chromium.googlesource.com/chromium/src/+/2880cd2941fe8ea000741b846a20413e50630bcc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -15 lines) Patch
M components/autofill/core/browser/webdata/autocomplete_sync_bridge.cc View 3 chunks +14 lines, -13 lines 0 comments Download
M components/autofill/core/browser/webdata/autocomplete_sync_bridge_unittest.cc View 5 chunks +104 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (11 generated)
skym
PTAL
3 years, 10 months ago (2017-01-27 15:11:05 UTC) #8
Patrick Noland
lgtm
3 years, 10 months ago (2017-01-30 21:55:33 UTC) #9
skym
Adding mathp@ for owners approval, PTAL
3 years, 10 months ago (2017-01-30 22:34:38 UTC) #11
Mathieu
autofill lgtm
3 years, 10 months ago (2017-01-31 15:44:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652393003/1
3 years, 10 months ago (2017-01-31 16:24:14 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 17:57:13 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2880cd2941fe8ea000741b846a20...

Powered by Google App Engine
This is Rietveld 408576698