Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Issue 2652393002: Float32ImageData, PerformanceObserver: no finalization needed. (Closed)

Created:
3 years, 11 months ago by sof
Modified:
3 years, 11 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Float32ImageData, PerformanceObserver: no finalization needed. R=haraken BUG= Review-Url: https://codereview.chromium.org/2652393002 Cr-Commit-Position: refs/heads/master@{#446289} Committed: https://chromium.googlesource.com/chromium/src/+/6c5013b14cf8829f24b35bd86562eef7b78c056d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/core/html/Float32ImageData.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceObserver.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
sof
please take a look. (I build with blink_gc_plugin_option_warn_unneeded_finalizer = true once in a while, warnings ...
3 years, 11 months ago (2017-01-26 07:20:50 UTC) #4
haraken
LGTM
3 years, 11 months ago (2017-01-26 09:36:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652393002/1
3 years, 11 months ago (2017-01-26 09:55:07 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 09:59:42 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6c5013b14cf8829f24b35bd86562...

Powered by Google App Engine
This is Rietveld 408576698