Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 2652363002: Disable OAuthRequestSignerTest.DecodeEncoded on OS_WIN (Closed)

Created:
3 years, 11 months ago by maniscalco
Modified:
3 years, 11 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable OAuthRequestSignerTest.DecodeEncoded on OS_WIN Test is failing on Win7. BUG=685352 TBR=msarda@chromium.org Review-Url: https://codereview.chromium.org/2652363002 Cr-Commit-Position: refs/heads/master@{#446276} Committed: https://chromium.googlesource.com/chromium/src/+/ee727fc9a40f5c579dc729c55f0118bfeb146812

Patch Set 1 #

Patch Set 2 : Fix test name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M google_apis/gaia/oauth_request_signer_unittest.cc View 1 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 24 (14 generated)
kjellander_chromium
It's still failing, I hope you don't mind I submit this (EMEA sheriff here).
3 years, 11 months ago (2017-01-26 07:47:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652363002/20001
3 years, 11 months ago (2017-01-26 07:47:33 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 11 months ago (2017-01-26 07:47:34 UTC) #10
kjellander_chromium
lgtm
3 years, 11 months ago (2017-01-26 07:47:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652363002/20001
3 years, 11 months ago (2017-01-26 07:48:14 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/350824)
3 years, 11 months ago (2017-01-26 07:54:09 UTC) #15
kjellander_chromium
TBR owner in google_apis/gaia
3 years, 11 months ago (2017-01-26 08:19:27 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652363002/20001
3 years, 11 months ago (2017-01-26 08:19:41 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/ee727fc9a40f5c579dc729c55f0118bfeb146812
3 years, 11 months ago (2017-01-26 08:24:01 UTC) #23
maniscalco
3 years, 11 months ago (2017-01-26 16:16:39 UTC) #24
Message was sent while issue was closed.
Nope, thanks for doing it!

On Wed, Jan 25, 2017 at 11:47 PM, <kjellander@chromium.org> wrote:

> It's still failing, I hope you don't mind I submit this (EMEA sheriff
> here).
>
> https://codereview.chromium.org/2652363002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698