|
|
Chromium Code Reviews|
Created:
3 years, 11 months ago by maniscalco Modified:
3 years, 11 months ago CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDisable OAuthRequestSignerTest.DecodeEncoded on OS_WIN
Test is failing on Win7.
BUG=685352
TBR=msarda@chromium.org
Review-Url: https://codereview.chromium.org/2652363002
Cr-Commit-Position: refs/heads/master@{#446276}
Committed: https://chromium.googlesource.com/chromium/src/+/ee727fc9a40f5c579dc729c55f0118bfeb146812
Patch Set 1 #Patch Set 2 : Fix test name #Messages
Total messages: 24 (14 generated)
The CQ bit was checked by maniscalco@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
kjellander@chromium.org changed reviewers: + kjellander@chromium.org
It's still failing, I hope you don't mind I submit this (EMEA sheriff here).
The CQ bit was checked by kjellander@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
lgtm
The CQ bit was checked by kjellander@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== Disable OAuthRequestSignerTest.DecodeEncoded on OS_WIN Test is failing on Win7. BUG=685352 ========== to ========== Disable OAuthRequestSignerTest.DecodeEncoded on OS_WIN Test is failing on Win7. BUG=685352 TBR=msarda@chromium.org ==========
kjellander@chromium.org changed reviewers: + msarda@chromium.org
TBR owner in google_apis/gaia
The CQ bit was checked by kjellander@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485418772095430,
"parent_rev": "4b7ec96e0cdf6ef721b15a31ea88d4c868f38929", "commit_rev":
"ee727fc9a40f5c579dc729c55f0118bfeb146812"}
Message was sent while issue was closed.
Description was changed from ========== Disable OAuthRequestSignerTest.DecodeEncoded on OS_WIN Test is failing on Win7. BUG=685352 TBR=msarda@chromium.org ========== to ========== Disable OAuthRequestSignerTest.DecodeEncoded on OS_WIN Test is failing on Win7. BUG=685352 TBR=msarda@chromium.org Review-Url: https://codereview.chromium.org/2652363002 Cr-Commit-Position: refs/heads/master@{#446276} Committed: https://chromium.googlesource.com/chromium/src/+/ee727fc9a40f5c579dc729c55f01... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/ee727fc9a40f5c579dc729c55f01...
Message was sent while issue was closed.
Nope, thanks for doing it! On Wed, Jan 25, 2017 at 11:47 PM, <kjellander@chromium.org> wrote: > It's still failing, I hope you don't mind I submit this (EMEA sheriff > here). > > https://codereview.chromium.org/2652363002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org. |
