Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2652353002:
Adding logging for third party certifcate tokens (Closed)
DescriptionAdding logging for third party certificate tokens
This is a simple change to log the issuer of the certificate
we use for Third Party Auth to make debugging easier.
BUG=685322
Review-Url: https://codereview.chromium.org/2652353002
Cr-Commit-Position: refs/heads/master@{#446174}
Committed: https://chromium.googlesource.com/chromium/src/+/d455f537abf27da5289674bbf96814172404e89d
Patch Set 1 #
Total comments: 2
Patch Set 2 : Adding more information to identify which cert was used. #Messages
Total messages: 20 (14 generated)
The CQ bit was checked by joedow@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
joedow@chromium.org changed reviewers: + lambroslambrou@chromium.org
PTAL! Thanks! Joe
Description was changed from ========== Adding logging for third party certifcate tokens This is a simple change to log the issuer of the certificate we use for Third Party Auth to make debugging easier. BUG=685322 ========== to ========== Adding logging for third party certificate tokens This is a simple change to log the issuer of the certificate we use for Third Party Auth to make debugging easier. BUG=685322 ==========
lgtm after addressing comment. https://codereview.chromium.org/2652353002/diff/1/remoting/host/token_validat... File remoting/host/token_validator_base.cc (right): https://codereview.chromium.org/2652353002/diff/1/remoting/host/token_validat... remoting/host/token_validator_base.cc:240: LOG(INFO) << "Using certificate issued by: '" Use HOST_LOG instead to avoid presubmit errors from logging at INFO level.
The CQ bit was checked by joedow@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Added start and expiry dates to the output as well. PTAL! https://codereview.chromium.org/2652353002/diff/1/remoting/host/token_validat... File remoting/host/token_validator_base.cc (right): https://codereview.chromium.org/2652353002/diff/1/remoting/host/token_validat... remoting/host/token_validator_base.cc:240: LOG(INFO) << "Using certificate issued by: '" On 2017/01/25 22:39:31, Lambros wrote: > Use HOST_LOG instead to avoid presubmit errors from logging at INFO level. Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by joedow@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from lambroslambrou@chromium.org Link to the patchset: https://codereview.chromium.org/2652353002/#ps20001 (title: "Adding more information to identify which cert was used.")
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485389859174940,
"parent_rev": "82b28ef9b1758cfcd3234a0bc6385f95239d9c01", "commit_rev":
"d455f537abf27da5289674bbf96814172404e89d"}
Message was sent while issue was closed.
Description was changed from ========== Adding logging for third party certificate tokens This is a simple change to log the issuer of the certificate we use for Third Party Auth to make debugging easier. BUG=685322 ========== to ========== Adding logging for third party certificate tokens This is a simple change to log the issuer of the certificate we use for Third Party Auth to make debugging easier. BUG=685322 Review-Url: https://codereview.chromium.org/2652353002 Cr-Commit-Position: refs/heads/master@{#446174} Committed: https://chromium.googlesource.com/chromium/src/+/d455f537abf27da5289674bbf968... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/d455f537abf27da5289674bbf968... |
