Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 2652343005: Add a timeout on the EG DrainUntilIdle (Closed)

Created:
3 years, 10 months ago by gambard
Modified:
3 years, 10 months ago
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a timeout on the EG DrainUntilIdle This CL adds a timeout of the cleanup functions of the ChromeTestCase. The cleanup functions wait for the UI thread and waits for both the UI and idling resources to idle. Without a timeout, this function hangs the application forever. BUG=686069 Review-Url: https://codereview.chromium.org/2652343005 Cr-Commit-Position: refs/heads/master@{#446663} Committed: https://chromium.googlesource.com/chromium/src/+/b3fe115b5f89f0ef92ae9b544db8294ebb5411e4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M ios/chrome/test/earl_grey/chrome_test_case.mm View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
gambard
baxley: TBR rohitrao: PTAL
3 years, 10 months ago (2017-01-27 14:01:00 UTC) #2
rohitrao (ping after 24h)
lgtm
3 years, 10 months ago (2017-01-27 14:04:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652343005/1
3 years, 10 months ago (2017-01-27 14:05:22 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 14:15:47 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b3fe115b5f89f0ef92ae9b544db8...

Powered by Google App Engine
This is Rietveld 408576698