Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2652343004: Use new Background method in memory perf test. (Closed)

Created:
3 years, 11 months ago by mikecase (-- gone --)
Modified:
3 years, 11 months ago
Reviewers:
perezju, eyaich1
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use new Background method in memory perf test. Replacing launching clock app (which does not work on AOSP devices) with new Background method. Review-Url: https://codereview.chromium.org/2652343004 Cr-Commit-Position: refs/heads/master@{#446434} Committed: https://chromium.googlesource.com/chromium/src/+/99a75259cfd52d1390fc0733f9dc18326c819f6f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -13 lines) Patch
M tools/perf/benchmarks/memory.py View 1 chunk +0 lines, -6 lines 0 comments Download
M tools/perf/page_sets/memory_top_10_mobile.py View 2 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
mikecase (-- gone --)
This change should let us run this benchmark on upstream webview bots.
3 years, 11 months ago (2017-01-26 19:12:51 UTC) #2
perezju
lgtm and thank you!!! I've been meaning to do this for a long long time!
3 years, 11 months ago (2017-01-26 19:22:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652343004/1
3 years, 11 months ago (2017-01-26 19:36:19 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 20:45:13 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/99a75259cfd52d1390fc0733f9dc...

Powered by Google App Engine
This is Rietveld 408576698