Replace source pointer in cc::CopyOutputRequest with a base::UnguessableToken

Replace source pointer in cc::CopyOutputRequest with a base::UnguessableToken

Soon we will be sending cc::CopyOutputRequests over IPC, but a copy
request can contain a source pointer which basically indicates who is 
the creator of the request (no dereferencing occurs), and sending this
raw pointer over IPC is not a good idea. This CL replaces the raw 
pointer with a base::UnguessableToken which acts a source ID.

BUG=672071
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2652343003
Cr-Commit-Position: refs/heads/master@{#447174}
Committed: https://chromium.googlesource.com/chromium/src/+/5846cb2c8ad77620776878f93a2b25be3b26449f

[Saman Sami, 2017-01-26 17:27:46]

Description was changed from

==========
Replace source pointer in cc::CopyRequest with a base::UnguessableToken

BUG=672071
==========

to

==========
Replace source pointer in cc::CopyRequest with a base::UnguessableToken

BUG=672071
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Saman Sami, 2017-01-26 17:35:03]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[Saman Sami, 2017-01-26 17:35:15]

Description was changed from

==========
Replace source pointer in cc::CopyRequest with a base::UnguessableToken

BUG=672071
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Replace source pointer in cc::CopyRequest with a base::UnguessableToken

BUG=672071
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Saman Sami, 2017-01-26 17:35:15]

samans@chromium.org changed reviewers:
+ fsamuel@chromium.org

[commit-bot: I haz the power, 2017-01-26 17:35:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 17:48:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 17:48:13]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Saman Sami, 2017-01-26 17:49:12]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 17:49:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 18:06:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 18:06:02]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Saman Sami, 2017-01-26 20:41:51]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 20:42:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-01-26 21:15:07]

Description was changed from

==========
Replace source pointer in cc::CopyRequest with a base::UnguessableToken

BUG=672071
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Replace source pointer in cc::CopyOutputRequest with a base::UnguessableToken

Soon we will be sending cc::CopyOutputRequests over IPC, but a copy
request can contain a source pointer which basically indicates where
the request who the request is initiated by, and sending this raw pointer
over IPC is not a good idea. This CL replaces the raw pointer with
a base::UnguessableToken which basically acts a source ID.

BUG=672071
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Saman Sami, 2017-01-26 21:17:11]

Description was changed from

==========
Replace source pointer in cc::CopyOutputRequest with a base::UnguessableToken

Soon we will be sending cc::CopyOutputRequests over IPC, but a copy
request can contain a source pointer which basically indicates where
the request who the request is initiated by, and sending this raw pointer
over IPC is not a good idea. This CL replaces the raw pointer with
a base::UnguessableToken which basically acts a source ID.

BUG=672071
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Replace source pointer in cc::CopyOutputRequest with a base::UnguessableToken

Soon we will be sending cc::CopyOutputRequests over IPC, but a copy
request can contain a source pointer which basically indicates who is 
the creator of the request (no dereferencing occurs), and sending this
raw pointer over IPC is not a good idea. This CL replaces the raw pointer with a
base::UnguessableToken which acts a source ID.

BUG=672071
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Saman Sami, 2017-01-26 21:17:20]

Description was changed from

==========
Replace source pointer in cc::CopyOutputRequest with a base::UnguessableToken

Soon we will be sending cc::CopyOutputRequests over IPC, but a copy
request can contain a source pointer which basically indicates who is 
the creator of the request (no dereferencing occurs), and sending this
raw pointer over IPC is not a good idea. This CL replaces the raw pointer with a
base::UnguessableToken which acts a source ID.

BUG=672071
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Replace source pointer in cc::CopyOutputRequest with a base::UnguessableToken

Soon we will be sending cc::CopyOutputRequests over IPC, but a copy
request can contain a source pointer which basically indicates who is 
the creator of the request (no dereferencing occurs), and sending this
raw pointer over IPC is not a good idea. This CL replaces the raw 
pointer with a base::UnguessableToken which acts a source ID.

BUG=672071
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Fady Samuel, 2017-01-26 21:22:42]

https://codereview.chromium.org/2652343003/diff/40001/cc/output/copy_output_r...
File cc/output/copy_output_request.h (right):

https://codereview.chromium.org/2652343003/diff/40001/cc/output/copy_output_r...
cc/output/copy_output_request.h:51: void set_source(base::UnguessableToken
source) { source_ = source; }
const base::UnguessableToken&

https://codereview.chromium.org/2652343003/diff/40001/cc/output/copy_output_r...
cc/output/copy_output_request.h:53: base::UnguessableToken source() const {
return *source_; }
const base::UnguessableToken&

https://codereview.chromium.org/2652343003/diff/40001/content/browser/media/c...
File content/browser/media/capture/web_contents_video_capture_device.cc (right):

https://codereview.chromium.org/2652343003/diff/40001/content/browser/media/c...
content/browser/media/capture/web_contents_video_capture_device.cc:84:
base::UnguessableToken GetSourceIdForCopyRequest() override;
const base::UnguessableToken&?

https://codereview.chromium.org/2652343003/diff/40001/content/browser/media/c...
content/browser/media/capture/web_contents_video_capture_device.cc:317:
base::UnguessableToken FrameSubscriber::GetSourceIdForCopyRequest() {
const base::UnguessableToken&

https://codereview.chromium.org/2652343003/diff/40001/content/browser/rendere...
File content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
(right):

https://codereview.chromium.org/2652343003/diff/40001/content/browser/rendere...
content/browser/renderer_host/render_widget_host_view_aura_unittest.cc:291:
base::UnguessableToken GetSourceIdForCopyRequest() override {
const base::UnguessableToken&

https://codereview.chromium.org/2652343003/diff/40001/content/browser/rendere...
File content/browser/renderer_host/render_widget_host_view_browsertest.cc
(right):

https://codereview.chromium.org/2652343003/diff/40001/content/browser/rendere...
content/browser/renderer_host/render_widget_host_view_browsertest.cc:274:
base::UnguessableToken GetSourceIdForCopyRequest() override {
const base::UnguessableToken&

https://codereview.chromium.org/2652343003/diff/40001/content/public/browser/...
File content/public/browser/render_widget_host_view_frame_subscriber.h (right):

https://codereview.chromium.org/2652343003/diff/40001/content/public/browser/...
content/public/browser/render_widget_host_view_frame_subscriber.h:73: virtual
base::UnguessableToken GetSourceIdForCopyRequest() = 0;
const base::UnguessableToken&

[Saman Sami, 2017-01-26 21:46:12]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 21:47:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-01-26 21:47:28]

PTAL

https://codereview.chromium.org/2652343003/diff/40001/cc/output/copy_output_r...
File cc/output/copy_output_request.h (right):

https://codereview.chromium.org/2652343003/diff/40001/cc/output/copy_output_r...
cc/output/copy_output_request.h:51: void set_source(base::UnguessableToken
source) { source_ = source; }
On 2017/01/26 21:22:42, Fady Samuel wrote:
> const base::UnguessableToken&

Done.

https://codereview.chromium.org/2652343003/diff/40001/cc/output/copy_output_r...
cc/output/copy_output_request.h:53: base::UnguessableToken source() const {
return *source_; }
On 2017/01/26 21:22:42, Fady Samuel wrote:
> const base::UnguessableToken&

Done.

https://codereview.chromium.org/2652343003/diff/40001/content/browser/media/c...
File content/browser/media/capture/web_contents_video_capture_device.cc (right):

https://codereview.chromium.org/2652343003/diff/40001/content/browser/media/c...
content/browser/media/capture/web_contents_video_capture_device.cc:84:
base::UnguessableToken GetSourceIdForCopyRequest() override;
On 2017/01/26 21:22:42, Fady Samuel wrote:
> const base::UnguessableToken&?

Done.

https://codereview.chromium.org/2652343003/diff/40001/content/browser/media/c...
content/browser/media/capture/web_contents_video_capture_device.cc:317:
base::UnguessableToken FrameSubscriber::GetSourceIdForCopyRequest() {
On 2017/01/26 21:22:42, Fady Samuel wrote:
> const base::UnguessableToken&

Done.

https://codereview.chromium.org/2652343003/diff/40001/content/browser/rendere...
File content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
(right):

https://codereview.chromium.org/2652343003/diff/40001/content/browser/rendere...
content/browser/renderer_host/render_widget_host_view_aura_unittest.cc:291:
base::UnguessableToken GetSourceIdForCopyRequest() override {
On 2017/01/26 21:22:42, Fady Samuel wrote:
> const base::UnguessableToken&

Done.

https://codereview.chromium.org/2652343003/diff/40001/content/browser/rendere...
File content/browser/renderer_host/render_widget_host_view_browsertest.cc
(right):

https://codereview.chromium.org/2652343003/diff/40001/content/browser/rendere...
content/browser/renderer_host/render_widget_host_view_browsertest.cc:274:
base::UnguessableToken GetSourceIdForCopyRequest() override {
On 2017/01/26 21:22:42, Fady Samuel wrote:
> const base::UnguessableToken&

Done.

https://codereview.chromium.org/2652343003/diff/40001/content/public/browser/...
File content/public/browser/render_widget_host_view_frame_subscriber.h (right):

https://codereview.chromium.org/2652343003/diff/40001/content/public/browser/...
content/public/browser/render_widget_host_view_frame_subscriber.h:73: virtual
base::UnguessableToken GetSourceIdForCopyRequest() = 0;
On 2017/01/26 21:22:42, Fady Samuel wrote:
> const base::UnguessableToken&

Done.

[Fady Samuel, 2017-01-26 21:49:34]

lgtm + nits

https://codereview.chromium.org/2652343003/diff/60001/cc/layers/layer.cc
File cc/layers/layer.cc (right):

https://codereview.chromium.org/2652343003/diff/60001/cc/layers/layer.cc#newc...
cc/layers/layer.cc:359: auto source = request->source();
const base::UnguessableToken& instead of auto?

https://codereview.chromium.org/2652343003/diff/60001/cc/surfaces/surface.cc
File cc/surfaces/surface.cc (right):

https://codereview.chromium.org/2652343003/diff/60001/cc/surfaces/surface.cc#...
cc/surfaces/surface.cc:90: auto source = copy_request->source();
const base::UnguessableToken&

[Saman Sami, 2017-01-26 21:50:29]

samans@chromium.org changed reviewers:
+ danakj@chromium.org, jam@chromium.org

[Saman Sami, 2017-01-26 21:51:06]

danakj@: Please review cc/
jam@: Please review content/

[Saman Sami, 2017-01-26 22:23:22]

https://codereview.chromium.org/2652343003/diff/60001/cc/layers/layer.cc
File cc/layers/layer.cc (right):

https://codereview.chromium.org/2652343003/diff/60001/cc/layers/layer.cc#newc...
cc/layers/layer.cc:359: auto source = request->source();
On 2017/01/26 21:49:34, Fady Samuel wrote:
> const base::UnguessableToken& instead of auto?

Done.

https://codereview.chromium.org/2652343003/diff/60001/cc/surfaces/surface.cc
File cc/surfaces/surface.cc (right):

https://codereview.chromium.org/2652343003/diff/60001/cc/surfaces/surface.cc#...
cc/surfaces/surface.cc:90: auto source = copy_request->source();
On 2017/01/26 21:49:34, Fady Samuel wrote:
> const base::UnguessableToken&

Done.

[Saman Sami, 2017-01-26 22:23:26]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 22:24:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-01-26 23:51:02]

https://codereview.chromium.org/2652343003/diff/80001/content/public/browser/...
File content/public/browser/render_widget_host_view_frame_subscriber.h (right):

https://codereview.chromium.org/2652343003/diff/80001/content/public/browser/...
content/public/browser/render_widget_host_view_frame_subscriber.h:1: //
Copyright (c) 2012 The Chromium Authors. All rights reserved.
why is this file in content/public? I only see it used inside content/, so it
should be in content/browser.

[commit-bot: I haz the power, 2017-01-27 01:12:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 01:12:39]

Dry run: This issue passed the CQ dry run.

[Saman Sami, 2017-01-27 18:46:08]

samans@chromium.org changed reviewers:
+ vmpstr@chromium.org

[Saman Sami, 2017-01-27 18:46:29]

vmpstr@: Please review cc/

[Saman Sami, 2017-01-27 19:15:05]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 19:15:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-01-27 19:21:07]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 19:21:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-01-27 19:22:05]

PTAL

https://codereview.chromium.org/2652343003/diff/80001/content/public/browser/...
File content/public/browser/render_widget_host_view_frame_subscriber.h (right):

https://codereview.chromium.org/2652343003/diff/80001/content/public/browser/...
content/public/browser/render_widget_host_view_frame_subscriber.h:1: //
Copyright (c) 2012 The Chromium Authors. All rights reserved.
On 2017/01/26 23:51:02, jam wrote:
> why is this file in content/public? I only see it used inside content/, so it
> should be in content/browser.

I moved it to content/browser/renderer_host.

[vmpstr, 2017-01-27 19:41:25]

cc lgtm with nits

https://codereview.chromium.org/2652343003/diff/120001/cc/layers/layer.cc
File cc/layers/layer.cc (right):

https://codereview.chromium.org/2652343003/diff/120001/cc/layers/layer.cc#new...
cc/layers/layer.cc:362: [source](const std::unique_ptr<CopyOutputRequest>& x) {
nit: capture source by reference, [&source]

https://codereview.chromium.org/2652343003/diff/120001/cc/layers/layer_unitte...
File cc/layers/layer_unittest.cc (right):

https://codereview.chromium.org/2652343003/diff/120001/cc/layers/layer_unitte...
cc/layers/layer_unittest.cc:90: base::UnguessableToken::Deserialize(0xdead,
0xbee0);
I think you mean 0xdead 0xf00d :P (jk)

https://codereview.chromium.org/2652343003/diff/120001/cc/surfaces/surface.cc
File cc/surfaces/surface.cc (right):

https://codereview.chromium.org/2652343003/diff/120001/cc/surfaces/surface.cc...
cc/surfaces/surface.cc:95: [source](const std::unique_ptr<CopyOutputRequest>& x)
{
nit: capture by reference

[Saman Sami, 2017-01-27 20:03:11]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[Saman Sami, 2017-01-27 20:03:20]

https://codereview.chromium.org/2652343003/diff/120001/cc/layers/layer.cc
File cc/layers/layer.cc (right):

https://codereview.chromium.org/2652343003/diff/120001/cc/layers/layer.cc#new...
cc/layers/layer.cc:362: [source](const std::unique_ptr<CopyOutputRequest>& x) {
On 2017/01/27 19:41:25, vmpstr wrote:
> nit: capture source by reference, [&source]

Done.

https://codereview.chromium.org/2652343003/diff/120001/cc/surfaces/surface.cc
File cc/surfaces/surface.cc (right):

https://codereview.chromium.org/2652343003/diff/120001/cc/surfaces/surface.cc...
cc/surfaces/surface.cc:95: [source](const std::unique_ptr<CopyOutputRequest>& x)
{
On 2017/01/27 19:41:25, vmpstr wrote:
> nit: capture by reference

Done.

[commit-bot: I haz the power, 2017-01-27 20:04:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 21:32:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 21:32:58]

Dry run: This issue passed the CQ dry run.

[miu, 2017-01-30 22:01:40]

miu@chromium.org changed reviewers:
+ miu@chromium.org

[miu, 2017-01-30 22:01:42]

lgtm

https://codereview.chromium.org/2652343003/diff/140001/content/browser/media/...
File content/browser/media/capture/web_contents_video_capture_device.cc (right):

https://codereview.chromium.org/2652343003/diff/140001/content/browser/media/...
content/browser/media/capture/web_contents_video_capture_device.cc:556:
view->CopyFromCompositingSurfaceToVideoFrame(
Note: It would be nice if this API was augmented to provide the "source token"
as well. But, probably not in this change.

At some point, we should probably re-think the APIs for capture from the RWHV
and DFH and compositor; and try to consolidate them into something simpler. They
are in their current state due to the evolution of compositing in Chrome over
the past 4+ years (some date to pre-Aura times).

[Fady Samuel, 2017-01-30 22:04:37]

On 2017/01/30 22:01:42, miu wrote:
> lgtm
> 
>
https://codereview.chromium.org/2652343003/diff/140001/content/browser/media/...
> File content/browser/media/capture/web_contents_video_capture_device.cc
(right):
> 
>
https://codereview.chromium.org/2652343003/diff/140001/content/browser/media/...
> content/browser/media/capture/web_contents_video_capture_device.cc:556:
> view->CopyFromCompositingSurfaceToVideoFrame(
> Note: It would be nice if this API was augmented to provide the "source token"
> as well. But, probably not in this change.
> 
> At some point, we should probably re-think the APIs for capture from the RWHV
> and DFH and compositor; and try to consolidate them into something simpler.
They
> are in their current state due to the evolution of compositing in Chrome over
> the past 4+ years (some date to pre-Aura times).

+1 Actually, we'd like to rethink them sooner rather than later for Mus and
Mus+Ash! I'd love to chat more if you have time!

[jam, 2017-01-31 01:03:47]

lgtm

[Saman Sami, 2017-01-31 01:07:20]

The CQ bit was checked by samans@chromium.org

[Saman Sami, 2017-01-31 01:07:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
fsamuel@chromium.org, vmpstr@chromium.org
Link to the patchset: https://codereview.chromium.org/2652343003/#ps140001
(title: "c")

[commit-bot: I haz the power, 2017-01-31 01:08:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 01:10:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 01:10:23]

Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Saman Sami, 2017-01-31 01:23:55]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 01:24:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 01:27:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 01:27:24]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Saman Sami, 2017-01-31 01:58:46]

The CQ bit was checked by samans@chromium.org

[Saman Sami, 2017-01-31 01:58:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
fsamuel@chromium.org, jam@chromium.org, vmpstr@chromium.org, miu@chromium.org
Link to the patchset: https://codereview.chromium.org/2652343003/#ps160001
(title: "c")

[commit-bot: I haz the power, 2017-01-31 01:59:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 03:09:51]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1485827926245970,
"parent_rev": "7f4313ab6f2a84dffb7394c6311afa8e1e0a5667", "commit_rev":
"5846cb2c8ad77620776878f93a2b25be3b26449f"}

[commit-bot: I haz the power, 2017-01-31 03:10:25]

Description was changed from

==========
Replace source pointer in cc::CopyOutputRequest with a base::UnguessableToken

Soon we will be sending cc::CopyOutputRequests over IPC, but a copy
request can contain a source pointer which basically indicates who is 
the creator of the request (no dereferencing occurs), and sending this
raw pointer over IPC is not a good idea. This CL replaces the raw 
pointer with a base::UnguessableToken which acts a source ID.

BUG=672071
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Replace source pointer in cc::CopyOutputRequest with a base::UnguessableToken

Soon we will be sending cc::CopyOutputRequests over IPC, but a copy
request can contain a source pointer which basically indicates who is 
the creator of the request (no dereferencing occurs), and sending this
raw pointer over IPC is not a good idea. This CL replaces the raw 
pointer with a base::UnguessableToken which acts a source ID.

BUG=672071
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2652343003
Cr-Commit-Position: refs/heads/master@{#447174}
Committed:
https://chromium.googlesource.com/chromium/src/+/5846cb2c8ad77620776878f93a2b...
==========

[commit-bot: I haz the power, 2017-01-31 03:10:27]

Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/5846cb2c8ad77620776878f93a2b...