Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2652323002: Convert MdSettingsUI to use the new navigation callbacks. (Closed)

Created:
3 years, 11 months ago by jam
Modified:
3 years, 11 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert MdSettingsUI to use the new navigation callbacks. BUG=682002 Review-Url: https://codereview.chromium.org/2652323002 Cr-Commit-Position: refs/heads/master@{#446103} Committed: https://chromium.googlesource.com/chromium/src/+/93392878eba7dd29a5cde0b510ce6ab514e50f3c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M chrome/browser/ui/webui/settings/md_settings_ui.h View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_ui.cc View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
jam
3 years, 11 months ago (2017-01-25 19:09:55 UTC) #11
Dan Beam
lgtm
3 years, 11 months ago (2017-01-25 19:30:36 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652323002/20001
3 years, 11 months ago (2017-01-25 20:14:49 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 20:20:19 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/93392878eba7dd29a5cde0b510ce...

Powered by Google App Engine
This is Rietveld 408576698