Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2652303002: [deoptimizer] Preserve double bit patterns correctly. (Closed)

Created:
3 years, 11 months ago by Michael Starzinger
Modified:
3 years, 11 months ago
Reviewers:
Igor Sheludko, Jarin
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[deoptimizer] Preserve double bit patterns correctly. This makes sure that the deoptimizer preserves the exact bit pattern of floating-point values (both 32-bit and 64-bit) up to the point where a potential {HeapNumber} is allocated. It in turn allows us to correctly recognize the {hole_nan_value} when stored into a {FixedDouleArray}. R=jarin@chromium.org TEST=mjsunit/regress/regress-crbug-684208 BUG=chromium:684208 Review-Url: https://codereview.chromium.org/2652303002 Cr-Commit-Position: refs/heads/master@{#42679} Committed: https://chromium.googlesource.com/v8/v8/+/7376e12e00b89d7ba476addeb05058147f8dd91d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -42 lines) Patch
M src/arm/deoptimizer-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/deoptimizer-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/deoptimizer.h View 9 chunks +52 lines, -14 lines 0 comments Download
M src/deoptimizer.cc View 10 chunks +37 lines, -19 lines 0 comments Download
M src/ia32/deoptimizer-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/deoptimizer-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/deoptimizer-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ppc/deoptimizer-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/s390/deoptimizer-s390.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/deoptimizer-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/deoptimizer-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/regress/regress-crbug-684208.js View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Jarin
lgtm, thanks!
3 years, 11 months ago (2017-01-26 07:41:18 UTC) #7
Michael Starzinger
Jaro: Thanks, landing. Igor: FYI.
3 years, 11 months ago (2017-01-26 09:09:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652303002/1
3 years, 11 months ago (2017-01-26 09:12:52 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 09:26:08 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/7376e12e00b89d7ba476addeb05058147f8...

Powered by Google App Engine
This is Rietveld 408576698