Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2652273003: [turbofan] Assign proper type to Object.prototype.toString(). (Closed)

Created:
3 years, 11 months ago by Benedikt Meurer
Modified:
3 years, 11 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Assign proper type to Object.prototype.toString(). BUG=v8:5267 R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2652273003 Cr-Commit-Position: refs/heads/master@{#42691} Committed: https://chromium.googlesource.com/v8/v8/+/ec00a78f3f002662493b4a5d19c36f70dea24f45

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/compiler/typer.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Benedikt Meurer
3 years, 11 months ago (2017-01-26 11:31:08 UTC) #1
Jarin
lgtm
3 years, 11 months ago (2017-01-26 11:31:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652273003/1
3 years, 11 months ago (2017-01-26 11:33:26 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 12:07:31 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/ec00a78f3f002662493b4a5d19c36f70dea...

Powered by Google App Engine
This is Rietveld 408576698