Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Issue 2652273002: Remove all service manifests from data_deps (Closed)

Created:
3 years, 11 months ago by Ken Rockot(use gerrit already)
Modified:
3 years, 11 months ago
CC:
chromium-reviews, rjkroege, piman+watch_chromium.org, feature-media-reviews_chromium.org, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, posciak+watch_chromium.org, chfremer+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, mcasas+watch+vc_chromium.org, alokp+watch_chromium.org, kalyank, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove all service manifests from data_deps Manifest outputs are never needed at runtime, so these entries in data_deps are inaccurate. They also break stuff now on some (non-tree-closing) builders. This removes all references to service manifest rules in data_deps. BUG=684406 TBR=ben@chromium.org Review-Url: https://codereview.chromium.org/2652273002 Cr-Commit-Position: refs/heads/master@{#446052} Committed: https://chromium.googlesource.com/chromium/src/+/ccb90539d5af550d7e753984fc79efd62f6495f9

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -106 lines) Patch
M components/filesystem/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M components/leveldb/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M components/nacl/broker/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M mash/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mash/catalog_viewer/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M mash/example/views_examples/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M mash/example/window_type_launcher/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mash/session/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M mash/simple_wm/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mash/task_viewer/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M mash/webtest/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M media/mojo/services/BUILD.gn View 2 chunks +0 lines, -5 lines 0 comments Download
M services/service_manager/README.md View 1 chunk +0 lines, -1 line 0 comments Download
M services/service_manager/background/tests/BUILD.gn View 2 chunks +0 lines, -5 lines 0 comments Download
M services/service_manager/runner/host/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M services/service_manager/tests/connect/BUILD.gn View 6 chunks +0 lines, -17 lines 0 comments Download
M services/service_manager/tests/lifecycle/BUILD.gn View 5 chunks +0 lines, -16 lines 0 comments Download
M services/service_manager/tests/service_manager/BUILD.gn View 2 chunks +0 lines, -5 lines 0 comments Download
M services/shape_detection/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M services/ui/demo/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/gpu/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M services/ui/test_wm/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M services/video_capture/BUILD.gn View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652273002/1
3 years, 11 months ago (2017-01-25 14:30:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/309686)
3 years, 11 months ago (2017-01-25 15:27:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652273002/20001
3 years, 11 months ago (2017-01-25 15:47:55 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 17:45:28 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ccb90539d5af550d7e753984fc79...

Powered by Google App Engine
This is Rietveld 408576698