Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Unified Diff: components/password_manager/core/browser/login_database.cc

Issue 2652243002: Implement Federated PSL Matches in Native Backends (Closed)
Patch Set: Addressed comments. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/login_database.cc
diff --git a/components/password_manager/core/browser/login_database.cc b/components/password_manager/core/browser/login_database.cc
index 586ba070e087251f476ae31977b171ba5b329af4..ff7d4da279494411702d1a367111191618c5bbc3 100644
--- a/components/password_manager/core/browser/login_database.cc
+++ b/components/password_manager/core/browser/login_database.cc
@@ -1217,26 +1217,26 @@ bool LoginDatabase::StatementToForms(
if (result == ENCRYPTION_RESULT_ITEM_FAILURE)
continue;
DCHECK_EQ(ENCRYPTION_RESULT_SUCCESS, result);
- if (matched_form && matched_form->signon_realm != new_form->signon_realm) {
- if (new_form->scheme != PasswordForm::SCHEME_HTML)
- continue; // Ignore non-HTML matches.
-
- if (IsPublicSuffixDomainMatch(new_form->signon_realm,
- matched_form->signon_realm)) {
- psl_domain_match_metric = PSL_DOMAIN_MATCH_FOUND;
- new_form->is_public_suffix_match = true;
- } else if (!new_form->federation_origin.unique() &&
- IsFederatedMatch(new_form->signon_realm,
- matched_form->origin)) {
- } else if (!new_form->federation_origin.unique() &&
- IsFederatedPSLMatch(new_form->signon_realm,
- matched_form->origin)) {
- psl_domain_match_metric = PSL_DOMAIN_MATCH_FOUND_FEDERATED;
- new_form->is_public_suffix_match = true;
- } else {
- continue;
+
+ if (matched_form) {
+ switch (GetMatchResult(*new_form, *matched_form)) {
+ case MatchResult::NO_MATCH:
+ continue;
+ case MatchResult::EXACT_MATCH:
+ break;
+ case MatchResult::PSL_MATCH:
+ psl_domain_match_metric = PSL_DOMAIN_MATCH_FOUND;
+ new_form->is_public_suffix_match = true;
+ break;
+ case MatchResult::FEDERATED_MATCH:
+ break;
+ case MatchResult::FEDERATED_PSL_MATCH:
+ psl_domain_match_metric = PSL_DOMAIN_MATCH_FOUND_FEDERATED;
+ new_form->is_public_suffix_match = true;
+ break;
}
}
+
forms->push_back(std::move(new_form));
}

Powered by Google App Engine
This is Rietveld 408576698