Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2019)

Unified Diff: chrome/browser/password_manager/native_backend_libsecret_unittest.cc

Issue 2652243002: Implement Federated PSL Matches in Native Backends (Closed)
Patch Set: Addressed comments. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/native_backend_libsecret_unittest.cc
diff --git a/chrome/browser/password_manager/native_backend_libsecret_unittest.cc b/chrome/browser/password_manager/native_backend_libsecret_unittest.cc
index 65721947286b9d05fb9f38d694f848ef7ea8ca9b..5c3515eb44c9839eded2b79fed7814baa0294109 100644
--- a/chrome/browser/password_manager/native_backend_libsecret_unittest.cc
+++ b/chrome/browser/password_manager/native_backend_libsecret_unittest.cc
@@ -701,6 +701,23 @@ TEST_F(NativeBackendLibsecretTest, FetchFederatedCredential) {
PasswordForm::SCHEME_HTML, nullptr));
}
+TEST_F(NativeBackendLibsecretTest, FetchPSLMatchedFederatedCredentialOnHTTPS) {
+ other_auth_.signon_realm = "federation://www.example.com/google.com";
+ other_auth_.federation_origin = url::Origin(GURL("https://google.com/"));
+ EXPECT_TRUE(CheckCredentialAvailability(other_auth_,
+ GURL("https://www.example.com/"),
+ PasswordForm::SCHEME_HTML, nullptr));
+}
+
+TEST_F(NativeBackendLibsecretTest,
+ DontFetchPSLMatchedFederatedCredentialOnHTTP) {
+ other_auth_.signon_realm = "federation://www.example.com/google.com";
+ other_auth_.federation_origin = url::Origin(GURL("https://google.com/"));
+ EXPECT_TRUE(CheckCredentialAvailability(other_auth_,
+ GURL("http://www.example.com/"),
+ PasswordForm::SCHEME_HTML, nullptr));
+}
+
TEST_F(NativeBackendLibsecretTest, BasicUpdateLogin) {
NativeBackendLibsecret backend(42);

Powered by Google App Engine
This is Rietveld 408576698