Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 2652233002: Use explicit WebString conversions in remaining components files (Closed)

Created:
3 years, 11 months ago by kinuko
Modified:
3 years, 11 months ago
Reviewers:
blundell
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, gcasto+watchlist_chromium.org, jam, darin-cc_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use explicit WebString conversions in remaining components files As we're deprecating implicit conversions for WebString <-> string16 replace them with explicit methods. (See crbug.com/667131 for more details) BUG=667131 R=blundell@chromium.org Review-Url: https://codereview.chromium.org/2652233002 Cr-Commit-Position: refs/heads/master@{#446082} Committed: https://chromium.googlesource.com/chromium/src/+/ca6ed36839c83303864e3383fb3fd16bda4ffd4c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M components/password_manager/content/renderer/credential_manager_client.cc View 2 chunks +10 lines, -6 lines 0 comments Download
M components/printing/renderer/print_web_view_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
kinuko
They're mechanical changes only-- can you review?
3 years, 11 months ago (2017-01-25 13:32:08 UTC) #3
blundell
lgtm
3 years, 11 months ago (2017-01-25 19:15:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652233002/1
3 years, 11 months ago (2017-01-25 19:16:49 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 19:26:06 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ca6ed36839c83303864e3383fb3f...

Powered by Google App Engine
This is Rietveld 408576698