Surface pushState event

third_party/WebKit/Source/core/frame/History.h

Index: third_party/WebKit/Source/core/frame/History.h
diff --git a/third_party/WebKit/Source/core/frame/History.h b/third_party/WebKit/Source/core/frame/History.h
index 4d3ab7d5e410eceb70b6475aabb9f9b61bf58f01..7d192715bc25a682c0c1d0eec99154e631ce78f0 100644
--- a/third_party/WebKit/Source/core/frame/History.h
+++ b/third_party/WebKit/Source/core/frame/History.h
@@ -59,13 +59,10 @@ class CORE_EXPORT History final : public GarbageCollectedFinalized<History>,
   void forward(ScriptState*);
   void go(ScriptState*, int delta);
 
-  void pushState(PassRefPtr<SerializedScriptValue> data,
-                 const String& title,
-                 const String& url,
-                 ExceptionState& exceptionState) {
-    stateObjectAdded(std::move(data), title, url, scrollRestorationInternal(),
-                     FrameLoadTypeStandard, exceptionState);
-  }
+  void pushState(PassRefPtr<SerializedScriptValue>,

[tdresser, 2017/01/26 21:30:52]

We do need parameter names here:

https://www.chromium.org/blink/coding-style

Leave meaningless variable names out of function declarations. A good rule of
thumb is if the parameter type name contains the parameter name (without
trailing numbers or pluralization), then the parameter name isn't needed.
Usually, there should be a parameter name for bools, strings, and numerical
types.

[sunjian, 2017/01/26 22:50:07]

Done.

+                 const String&,
+                 const String&,
+                 ExceptionState&);
 
   void replaceState(PassRefPtr<SerializedScriptValue> data,
                     const String& title,