Surface pushState event

third_party/WebKit/Source/core/frame/History.h

 /*
  * Copyright (C) 2007 Apple Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 41 matching lines @@
  public:
   static History* create(LocalFrame* frame) { return new History(frame); }
 
   unsigned length() const;
   SerializedScriptValue* state();
 
   void back(ScriptState*);
   void forward(ScriptState*);
   void go(ScriptState*, int delta);
 
-  void pushState(PassRefPtr<SerializedScriptValue> data,
-                 const String& title,
-                 const String& url,
-                 ExceptionState& exceptionState) {
-    stateObjectAdded(std::move(data), title, url, scrollRestorationInternal(),
-                     FrameLoadTypeStandard, exceptionState);
-  }
+  void pushState(PassRefPtr<SerializedScriptValue>,

[tdresser, 2017/01/26 21:30:52]

We do need parameter names here:

https://www.chromium.org/blink/coding-style

Leave meaningless variable names out of function declarations. A good rule of
thumb is if the parameter type name contains the parameter name (without
trailing numbers or pluralization), then the parameter name isn't needed.
Usually, there should be a parameter name for bools, strings, and numerical
types.

[sunjian, 2017/01/26 22:50:07]

Done.

+                 const String&,
+                 const String&,
+                 ExceptionState&);
 
   void replaceState(PassRefPtr<SerializedScriptValue> data,
                     const String& title,
                     const String& url,
                     ExceptionState& exceptionState) {
     stateObjectAdded(std::move(data), title, url, scrollRestorationInternal(),
                      FrameLoadTypeReplaceCurrentItem, exceptionState);
   }
 
   void setScrollRestoration(const String& value);
@@ skipping 25 matching lines @@
                         ExceptionState&);
   SerializedScriptValue* stateInternal() const;
   HistoryScrollRestorationType scrollRestorationInternal() const;
 
   RefPtr<SerializedScriptValue> m_lastStateObjectRequested;
 };
 
 }  // namespace blink
 
 #endif  // History_h