Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2652163003: Fix team tag for Blink>Bindings (Closed)

Created:
3 years, 11 months ago by ymzhang1
Modified:
3 years, 11 months ago
Reviewers:
haraken, RobertoCN
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixing team tag (Blink>Bindings) Since blink-bindings-reviews@ does not exist, changing idl_parser TEAM tag to blink-reviews-bindigs@ R=Haraken,RobertoCN Review-Url: https://codereview.chromium.org/2652163003 Cr-Commit-Position: refs/heads/master@{#446131} Committed: https://chromium.googlesource.com/chromium/src/+/74b3d663d26acc39536e3edf799c3e3caa8ad5a3

Patch Set 1 #

Patch Set 2 : Merge branch 'master' of https://chromium.googlesource.com/chromium/src into binding_change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/idl_parser/OWNERS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (10 generated)
ymzhang1
3 years, 11 months ago (2017-01-25 19:46:07 UTC) #2
RobertoCN
lgtm
3 years, 11 months ago (2017-01-25 20:01:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652163003/1
3 years, 11 months ago (2017-01-25 20:02:34 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/350218)
3 years, 11 months ago (2017-01-25 20:12:31 UTC) #7
RobertoCN
Haraken@, Could you review this change? We need an owner's stamp.
3 years, 11 months ago (2017-01-25 20:18:18 UTC) #10
haraken
LGTM
3 years, 11 months ago (2017-01-25 20:20:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652163003/1
3 years, 11 months ago (2017-01-25 21:50:35 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 21:56:37 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/74b3d663d26acc39536e3edf799c...

Powered by Google App Engine
This is Rietveld 408576698